search

tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.72k stars 4.76k forks source link

The power beacon does not attract teslas. #74069

Open VladinXXV opened 1 year ago

VladinXXV commented 1 year ago

Round ID: N/A

Testmerges: N/A

Reproduction:

Tesloose. Have a power beacon wrenched and activated while on a powered wire. Wait. Nothing.

I actually tried using up to 9 beacons at once before I decided something was up. #16188 was the PR that originally allowed the singularity beacon to attract teslas (while also renaming it to the power beacon). Back when this PR was made, it relied on the fact that the tesla was a subtype of singularities. I'm not sure if that's still relevant, though. #59868 made it so the power beacon looked for things with the singularity component. This includes Nar'Sie, but does not include teslas. image image

Sealed101 commented 1 year ago

seems like in #55096 with the implementation of singulo component tesla was not assigned that component in any way, and the beacon relies on setting the signulo component's target to itself

https://github.com/tgstation/tgstation/blob/537651575e041396a0a16dce21c0738d46a8cd0d/code/game/machinery/syndicatebeacon.dm#L20-L33

VladinXXV commented 1 year ago

that's more or less what i said in the last two sentences but yeah

MrMelbert commented 1 year ago

I wanna say the target var just doesn't work, last time I tried changing it from an active singularity it didn't affect its movement whatsoever