search

tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.7k stars 4.92k forks source link

Space cleaner foam grenades do not clean the color reagent #7640

Closed ghost closed 7 years ago

ghost commented 9 years ago

on tiles or otherwise

theOperand commented 9 years ago

@Iamgoofball

Iamgoofball commented 9 years ago

does it work with things other then foam such as smoke and spray bottles?

ghost commented 9 years ago

Don't think so

Iamgoofball commented 9 years ago

i just tested, it works with spray bottles which makes this a problem on @Cheridan 's end

ghost commented 9 years ago

No, because it didn't work before cheridan's foam update

Look at the date this issue was created goof.

Iamgoofball commented 9 years ago

oh

Cheridan commented 9 years ago

rekt

phil235 commented 9 years ago

Currently nothing can clean the color reagent because it's coded to use the target atom's color var, and plenty of other things use that variable. So anything that is coded to clean that reagent would also be able to remove the blob's color or space vines color for example. The solution could be to make the color reagent use another variable altogether, and then make space cleaner and water reset this new var.

nullbear commented 8 years ago

OR you could have things with a modifiable/non_modifiable color (such as blobs, the red space carp plush, etc) have a flag (flags |= UNCOLORABLE) and then space cleaner (and colorful reagent) would only color or uncolor objects that do not have that flag.

(is this a good solution?)

PKPenguin321 commented 8 years ago

A whole new flag for one reagent seems kind of tacky

nullbear commented 8 years ago

it would be for two reagents + sinks and adminshittery The alternative would be like... harder and more complex anyways.