tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.72k stars 4.75k forks source link

Being forced to join round as random job after setting 'Return to lobby if job unavailable' and not getting preferred jobs #77609

Closed DeerJesus closed 1 year ago

DeerJesus commented 1 year ago

Round ID:

212491

Testmerges:

77307: 'Revert "Bumps rust-g to 3.0.0 "' by MrStonedOne at commit 8dad0feceb

77447: 'Trying to qdelete a callback now lags the server instead.' by MrStonedOne at commit e15efd1604

Reproduction:

set job to clown or AI only set to 'return to lobby as unavailable' spawn in as a random job anyway for some reason ?? suicide roundstart because my extremely goofy looking clown character is now a paramedic

also it was a round where everyone started drunk and in vomit so maybe that had something to do with it

MrMelbert commented 1 year ago

In the future you should include your ckey when reporting job issues, as we can check the job debug file to verify what went wrong

However in this situation, it appears to be obvious

[2023-08-14 05:25:23.746] DEBUG-JOB: DO, Handle unrejectable unassigned
[2023-08-14 05:25:23.747] DEBUG-JOB: GRJ Giving random job, Player: ThatKindOfJack
[2023-08-14 05:25:23.747] DEBUG-JOB: Running AR, Player: ThatKindOfJack, Job: /datum/job/shaft_miner, LateJoin: 0
[2023-08-14 05:25:23.747] DEBUG-JOB: Player: ThatKindOfJack is now Rank: Shaft Miner, JCP:1, JPL:3
[2023-08-14 05:25:23.748] DEBUG-JOB: GRJ Random job given, Player: ThatKindOfJack, Job: /datum/job/shaft_miner
[2023-08-14 05:25:23.748] DEBUG-JOB: GRJ Giving random job, Player: Oilysnake
[2023-08-14 05:25:23.748] DEBUG-JOB: Running AR, Player: Oilysnake, Job: /datum/job/paramedic, LateJoin: 0
[2023-08-14 05:25:23.749] DEBUG-JOB: Player: Oilysnake is now Rank: Paramedic, JCP:0, JPL:2
[2023-08-14 05:25:23.749] DEBUG-JOB: GRJ Random job given, Player: Oilysnake, Job: /datum/job/paramedic
[2023-08-14 05:25:23.749] DEBUG-JOB: GRJ Giving random job, Player: Dr . Oof
[2023-08-14 05:25:23.750] DEBUG-JOB: GRJ skipping command role, Player: Dr . Oof, Job: /datum/job/chief_medical_officer
[2023-08-14 05:25:23.750] DEBUG-JOB: Running AR, Player: Dr . Oof, Job: /datum/job/curator, LateJoin: 0
[2023-08-14 05:25:23.750] DEBUG-JOB: Player: Dr . Oof is now Rank: Curator, JCP:0, JPL:1
[2023-08-14 05:25:23.751] DEBUG-JOB: GRJ Random job given, Player: Dr . Oof, Job: /datum/job/curator
[2023-08-14 05:25:23.751] DEBUG-JOB: DO, Ending handle unrejectable unassigned

And much later down the line

[2023-08-14 05:33:18.974] DYNAMIC: Roundstart Revolution discarded Kofka Palazzino from head revolutionary due to ineligibility.
DeerJesus commented 1 year ago

MY FUCKING ANTAG TOKEN!!

On Mon, Aug 14, 2023 at 12:31 PM MrMelbert @.***> wrote:

In the future you should include your ckey when reporting job issues, as we can check the job debug file to verify what went wrong

However in this situation, it appears to be obvious

  • Dynamic selected Revolution roundstart
  • You were chosen as the initial headrev
  • You could not become AI (invalid role) and another player rolled Clown before you, leaving you with no possible roles
  • Because you had no roles, but were selected for an antag, you were given a random job

And much later down the line

  • Something happened to you, no idea what, but you were in an invalid state to take on Headrev when it actually executed

[2023-08-14 05:33:18.974] DYNAMIC: Roundstart Revolution discarded Kofka Palazzino from head revolutionary due to ineligibility.

— Reply to this email directly, view it on GitHub https://github.com/tgstation/tgstation/issues/77609#issuecomment-1677775227, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZXNHPMCBSQROGY77YJWPTXVJOGHANCNFSM6AAAAAA3PGDJJ4 . You are receiving this because you authored the thread.Message ID: @.***>

DeerJesus commented 1 year ago

Hold on, I haven’t been able to roll antag for a WHILE now. Is there a possibility this is repeating itself?

DeerJesus commented 1 year ago

Nvm it was because I suicided due to getting paramedic on the wrong character and it didn’t tell me I even had headrev because of the delay