search

tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.65k stars 4.82k forks source link

Pirate ship sprite from above a zlevel is fucked #84597

Open DaydreamIQ opened 2 weeks ago

DaydreamIQ commented 2 weeks ago

Reporting client version: 515.1641

Issue Summary

Round ID:

231520

Testmerges:

Reproduction:

image This is from the skeleton pirate ship from a level above it

Sadboysuss commented 1 week ago

Shit be fucked

Profakos commented 6 days ago

https://github.com/tgstation/tgstation/blob/c3562f828f3df6b003b18f3efd364a8cd0f02e0e/code/game/turfs/open/floor/hull.dm#L19

Seems to be the only line that spawns this effect? Do the shuttles temporarily overwrite the area above their ceilings to be non space, thus spawning these errors when a shuttle moves into a multiZ environment?

https://github.com/tgstation/tgstation/blob/c3562f828f3df6b003b18f3efd364a8cd0f02e0e/code/modules/shuttle/docking.dm#L175-L180

I don't see if this changes the area though. Perhaps I should breakpoint it, and see what the actual area is.

Profakos commented 6 days ago

Okay, turns out I have just misread a line, and now I see the causes this issue, its much simpler than I thought.

https://github.com/tgstation/tgstation/blob/c3562f828f3df6b003b18f3efd364a8cd0f02e0e/code/game/turfs/open/floor/hull.dm#L13-L19

This spawns when the area is space but not nearstation. Shuttles move around the map, under space tiles, thus spawning the errors.