tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.71k stars 4.94k forks source link

False Alarm picking Aurora Caelus makes space green forever #84651

Open luxidoptera opened 3 months ago

luxidoptera commented 3 months ago

Issue Summary

Today I discovered something pretty funny: the False Alarm random event can, occasionally, pick the Aurora Caelus event to "false alarm" over. The fun thing is, this actually does trigger the Caelus event, and causes space tiles to light up green and the music to play, which is lovely. What isn't lovely is that because this Caelus event was technically triggered by a false alarm, the end trigger never gets tripped, so even long after the music has stopped, space just...stays green. Forever.

Ultimately a harmless issue, just funny.

image image

Round ID:

N/A (solo local play)

Testmerges:

Unknown

Reproduction:

This issue comes down entirely to RNG as to whether or not it happens. Join server; wait for aurora caelus event; see if it ever actually stops. If it doesn't, bravo, you've just had the issue I did lol

Rhials commented 3 months ago

Tested and reproduced on live. First off, the fake announcement shouldn't be changing space at all, and since the event kills right after being set up it makes sense that it doesn't clean up properly.

I did notice, however, that some bits weren't properly cleaning up after the real event was run and done.

After fake event:

image

After real event: image

Those weird splotches of green shouldn't be there, I don't think. No idea what the correlation is though. (Map is Wawastation in case anyone wants to look into it).

Rhials commented 1 month ago

This appears to still be an issue. It occurred on round 235392.