search

tguerin / newton

An Easy To Use Particle Emitter
https://newton.7omtech.fr
MIT License
22 stars 7 forks source link

Register license of this project #14

Closed Joshix-1 closed 9 months ago

Joshix-1 commented 9 months ago

Call addLicense to make it easier for projects using this to credit this library.

tguerin commented 9 months ago

Do you mean you would like the Newton widget to call addLicense? Or would you like a helper Newton.addLicense that would load the license file and add the collector?

For the first case, it would be weird for the widget to do that cause it should be done once and it's not impossible for an app to instantiate multiple time the widget. It would require to have a static field somewhere to remind we added the licence. I think I would prefer the second option, let the developer call Newton.addLicense() on app starts. Wdyt?

Joshix-1 commented 9 months ago

I think libraries are supposed to do that automatically once on import

tguerin commented 9 months ago

Do you have libraries in mind which do that already? Feels dirty to have a kind of static code called upon widget use.

Joshix-1 commented 9 months ago

I'm stupid, you having the LICENSE file is already enough. It's already displayed in the licenses page