search

tgvashworth / ServiceWorker-Polyfill

[DEPRECATED] JavaScript ServiceWorker implementation, enabling exploration by authors.
66 stars 7 forks source link

Broken use of url.origin #52

Closed jakearchibald closed 10 years ago

jakearchibald commented 10 years ago

_WorkerRegistry uses url.origin which isn't implemented.

At the moment, undefined == undefined, so origin checks always pass.

See https://github.com/passy/node-dom-urls/issues/1

passy commented 10 years ago

Fixed in v0.1.1 but I discovered a lot of other issues in terms of spec compliance. On the upside, the browsers don't seem to agree on anything either ... Chrome and Firefox handle certain edge cases completely different.

passy commented 10 years ago

Usage in the code looks correct to me and the URL polyfill implements .origin now. Can this be closed?

jakearchibald commented 10 years ago

Yep! On 2 Feb 2014 04:37, "Pascal Hartig" notifications@github.com wrote:

Usage in the code looks correct to me and the URL polyfill implements .origin now. Can this be closed?

— Reply to this email directly or view it on GitHubhttps://github.com/phuu/ServiceWorker-Polyfill/issues/52#issuecomment-33901806 .