tgvashworth / fetch-engine

A smart request-making library
24 stars 6 forks source link

Add Karma runner and BrowserStack testing #54

Closed tgvashworth closed 8 years ago

tgvashworth commented 8 years ago

PR for #16, superseding #53.

Karma Runner

Karma facilitates the configuration for adding extra services to the testing process. In this case adding BrowserStack testing was just a matter of installing karma-browserstack-launcher and adding a config file.

BrowserStack

karma-browserstack-launcher expects BROWSERSTACK_USERNAME and BROWSERSTACK_KEY environment variables to be set for BrowserStack authentication.

These can be acquired in the BrowserStack account settings page at the bottom Automate section:

browserstack_automate

And added in the Travis repo settings page at the Environment Variables section:

travis_environment_vars

BrowserStack Browsers & Mobile Devices for JavaScript Testing

Testing Configuration

The files for testing configuration are in ./testing/. All in TypeScript for linting, and compiled by the npm script build-conf (I haven't found a way to pipe tsc directly to karma without creating files).

tgvashworth commented 8 years ago

Just added some Browserstack keys to the Travis job.

tgvashworth commented 8 years ago

Plan:

tgvashworth commented 8 years ago

@thelambdaparty This squashed your commits into one, but removed your authorship. I'm really sorry about that — totally unintentional. Will try to set the author back to you and force push to the branch.

ghost commented 8 years ago

:smile: no problem