feat: add Karma runner and BrowserStack testing

tgvashworth / fetch-engine

A smart request-making library

24 stars 6 forks source link

feat: add Karma runner and BrowserStack testing #55

Closed tgvashworth closed 8 years ago

tgvashworth commented 8 years ago

[x] Get the build passing in electron
[x] Get the build passing on travis
[ ] Get the build passing on browserstack
[ ] Get the build passing on all required browsers

tgvashworth commented 8 years ago

@thelambdaparty I think you're able to push to this branch. My suggestion is that we use a rebase workflow on this branch until it's mergable:

Something like this (untested):

$ git remote add phuu https://github.com/phuu/fetch-engine
$ git branch -D karma
$ git fetch phuu karma
$ git checkout karma
... do some work & commit ...
$ git pull --rebase
$ git push

tgvashworth commented 8 years ago

I'm going to try to get it passing on Browserstack consistently before pushing any more — would like to avoid broken builds on this branch.

tgvashworth commented 8 years ago

Hmm. There are some complications here:

This module should work in node and the browser, so we need to be selective about which tests we run where. Unsure how to do this right now.
The change to use karma means we're missing some tests. Updating the karma glob to dist/**/*.test.js doesn't work and I'm not sure why, so I'm going to look at other options for compiling
fetch-engine shouldn't bundle it's own Promise implementation — its has to be bring-your-own so that users can choose to polyfill or not, depending on their use case. For testing in browsers, we need to add that polyfill to the global scope manually. Do you know how to configure webpack to add it?
I also see the Browserstack disconnections and they're a bit worrying. I don't really trust the karma runner tbh — it's just a bit magical. Not sure what do do about that either.

ghost commented 8 years ago

I was able to fix all of those problems, except for the disconnections (which is the most important one :sweat:).

Seems like a problem with karma, because i also tried with sauce labs and it had the same disconnections. I watched the test going on browserstack and it keeps waiting for a response from the test server (when it's ready to run tests), so it's surely something with the karma-browserstack-launcher.

I saw the manual-browserstack branch. I'll wait for your development there, if it goes well we can just drop this branch, as you'll have more control and config options with that setup.

tgvashworth commented 8 years ago

@thelambdaparty What do you think of this: https://github.com/phuu/fetch-engine/pull/64 ?

tgvashworth commented 8 years ago

Going to close this because #64 is looking like the way forward. Thanks for your work here @thelambdaparty!