Closed tgvashworth closed 8 years ago
@thelambdaparty I think you're able to push to this branch. My suggestion is that we use a rebase workflow on this branch until it's mergable:
Something like this (untested):
$ git remote add phuu https://github.com/phuu/fetch-engine
$ git branch -D karma
$ git fetch phuu karma
$ git checkout karma
... do some work & commit ...
$ git pull --rebase
$ git push
I'm going to try to get it passing on Browserstack consistently before pushing any more — would like to avoid broken builds on this branch.
Hmm. There are some complications here:
dist/**/*.test.js
doesn't work and I'm not sure why, so I'm going to look at other options for compilingI was able to fix all of those problems, except for the disconnections (which is the most important one :sweat:).
Seems like a problem with karma, because i also tried with sauce labs and it had the same disconnections. I watched the test going on browserstack and it keeps waiting for a response from the test server (when it's ready to run tests), so it's surely something with the karma-browserstack-launcher.
I saw the manual-browserstack branch. I'll wait for your development there, if it goes well we can just drop this branch, as you'll have more control and config options with that setup.
@thelambdaparty What do you think of this: https://github.com/phuu/fetch-engine/pull/64 ?
Going to close this because #64 is looking like the way forward. Thanks for your work here @thelambdaparty!