tgxn / Backup

A Backup plugin for the Bukkit Server API.
http://bukkitbackup.com
GNU General Public License v3.0
23 stars 14 forks source link

Does not support bukkit.yml "settings: world-container: < subfolder >" #91

Closed ohjays closed 12 years ago

ohjays commented 12 years ago

backup version build #80

backup won't find worlds if they have been relocated in a subfolder as per bukkit.yml

settings: world-container: < subfolder >

which enables placing all worlds in a separate subfolder ie ".minecraftmyworld" ".minecraftmyworld_nether"

so backup fails for me ive checked the config there apears no option to specify a subfolder to scan in

[INFO] CONSOLE: Forcing save.. 10:46:16 [INFO] CONSOLE: Save complete. 10:46:16 [INFO] CONSOLE: Disabling level saving.. 10:46:16 [INFO] java.io.FileNotFoundException: Source 'world' does not exist 10:46:16 [INFO] at net.tgxn.bukkit.backup.utils.FileUtils.copyDirectory(FileUtils.java:200) 10:46:16 [INFO] at net.tgxn.bukkit.backup.utils.FileUtils.copyDirectory(FileUtils.java:141) 10:46:16 [INFO] at net.tgxn.bukkit.backup.utils.FileUtils.copyDirectory(FileUtils.java:110) 10:46:16 [INFO] at net.tgxn.bukkit.backup.threading.BackupTask.backupWorlds(BackupTask.java:207) 10:46:16 [INFO] at net.tgxn.bukkit.backup.threading.BackupTask.processBackup(BackupTask.java:109) 10:46:16 [INFO] at net.tgxn.bukkit.backup.threading.BackupTask.run(BackupTask.java:94) 10:46:16 [INFO] at org.bukkit.craftbukkit.scheduler.CraftWorker.run(CraftWorker.java:34) 10:46:16 [INFO] at java.lang.Thread.run(Unknown Source) 10:46:16 [INFO] [Backup] Failed to copy world: IO Exception. 10:46:16 [SEVERE] java.lang.NullPointerException 10:46:16 [SEVERE] at net.tgxn.bukkit.backup.utils.FileUtils.zipDir(FileUtils.java:512) 10:46:16 [SEVERE] at net.tgxn.bukkit.backup.utils.FileUtils.zipDir(FileUtils.java:492) 10:46:16 [SEVERE] at net.tgxn.bukkit.backup.threading.BackupTask.doCopyAndZIP(BackupTask.java:359) 10:46:16 [SEVERE] at net.tgxn.bukkit.backup.threading.BackupTask.backupWorlds(BackupTask.java:214) 10:46:16 [SEVERE] at net.tgxn.bukkit.backup.threading.BackupTask.processBackup(BackupTask.java:109) 10:46:16 [SEVERE] at net.tgxn.bukkit.backup.threading.BackupTask.run(BackupTask.java:94) 10:46:16 [SEVERE] at org.bukkit.craftbukkit.scheduler.CraftWorker.run(CraftWorker.java:34) 10:46:16 [SEVERE] at java.lang.Thread.run(Unknown Source)

tgxn commented 12 years ago

Absolutely need this.

tgxn commented 12 years ago

This is done, but the build failed because I was in the middle of upgrading Jenkins :P

I'll re-build and provide link when it's working.

ohjays commented 12 years ago

great one of the last plugins i'm waiting on :)

tgxn commented 12 years ago

http://ci.tgxn.net/job/dev-Backup/85/

All good :)

ohjays commented 12 years ago

looks good, but any idea why your zips wont work with worldedit, i do some myself under linux and they work ??

thanks

tgxn commented 12 years ago

I'm not even too sure about how WorldEdit works :P

Someone said that my backups worked with it one day, and i was like, oh, cool!

I should really edumacate myself, so i can answer questions like that!

ohjays commented 12 years ago

your doing pretty well with this plugin. I notice mc (midnight commander - thats under linux ) has issues with opening your jar and zip for the plugin as well ( not your backups ) weird to many zip format variations id say.

ill poke around more sometime, suspect worldedit it picky :) backup are working that the main thing for me

Hmm , just noticed one big difference in my backups i also insert the "worlds" folder into the zip ie backup.zip

whereas yours are backup.zip - the files

looks like it requires the worlds folder to be present as well ? i guess that explains the message it spews out "Target world not present in zip"

Sorry for going off topic by the way

tgxn commented 12 years ago

Not sure about Zip and the Jar, they are all generated by Jenkins.

I hear that it is quite picky, not sure what format the name is supposed to be.

if you do find a way to make my plugin more compatible (layout, naming, etc) send me an email through: gamerx@bukkitbackup.com

ohjays commented 12 years ago

note I,m running the latest worldedit dev snapshots as well forgot to mention that. But it looks like the files need to be in the worlds name subfolder inside the zip