th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.95k stars 507 forks source link

[Bug]: Restart on config changes doesnt work on plugin options #1630

Open inson1 opened 10 months ago

inson1 commented 10 months ago

Preflight Checklist

YouTube Music (Application) Version

3.2.1

Are you using the portable version of the YouTube Music Application?

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. enable Visualizer plugin
  2. play song with video
  3. change type of Visualizer
  4. nothing, type of Visualizer didnt changed

Expected Behavior

It should trigger restart or change the type

Actual Behavior

Doesnt do anything, like I didnt do anything, no restart or type changed (in menu yes, in video no)

Enabled plugins

{
    "window-size": {
        "width": 204,
        "height": 147
    },
    "window-maximized": false,
    "window-position": {
        "x": 800,
        "y": 108
    },
    "url": "https://music.youtube.com/watch?v=RL8y-a15xMQ&list=OLAK5uy_kMf7SarRBJdJEtMktptA20TbKaGo92JEc&index=0",
    "options": {
        "tray": true,
        "appVisible": true,
        "autoUpdates": true,
        "alwaysOnTop": false,
        "hideMenu": true,
        "hideMenuWarned": true,
        "startAtLogin": true,
        "disableHardwareAcceleration": false,
        "removeUpgradeButton": false,
        "restartOnConfigChanges": true,
        "trayClickPlayPause": true,
        "autoResetAppCache": false,
        "resumeOnStart": true,
        "likeButtons": "",
        "proxy": "",
        "startingPage": "",
        "overrideUserAgent": false,
        "themes": [],
        "language": "en"
    },
    "plugins": {
        "adblocker": {
            "enabled": true,
            "cache": true,
            "blocker": "In player",
            "additionalBlockLists": [],
            "disableDefaultLists": false
        },
        "album-color-theme": {
            "enabled": true
        },
        "ambient-mode": {
            "enabled": false,
            "quality": 50,
            "buffer": 30,
            "interpolationTime": 1500,
            "blur": 500,
            "size": 100,
            "opacity": 1,
            "fullscreen": false
        },
        "audio-compressor": {
            "enabled": false
        },
        "blur-nav-bar": {
            "enabled": false
        },
        "bypass-age-restrictions": {
            "enabled": true
        },
        "captions-selector": {
            "enabled": false,
            "disableCaptions": false,
            "autoload": true,
            "lastCaptionsCode": ""
        },
        "compact-sidebar": {
            "enabled": false
        },
        "crossfade": {
            "enabled": false,
            "fadeInDuration": 1500,
            "fadeOutDuration": 5000,
            "secondsBeforeEnd": 10,
            "fadeScaling": "linear"
        },
        "disable-autoplay": {
            "applyOnce": false
        },
        "discord": {
            "enabled": false,
            "autoReconnect": true,
            "activityTimoutEnabled": true,
            "activityTimoutTime": 600000,
            "playOnYouTubeMusic": true,
            "hideGitHubButton": false,
            "hideDurationLeft": false,
            "listenAlong": true,
            "activityTimeoutEnabled": true,
            "activityTimeoutTime": 600000
        },
        "downloader": {
            "enabled": true,
            "selectedPreset": "mp3 (256kbps)",
            "customPresetSetting": {
                "extension": "mp3",
                "ffmpegArgs": [
                    "-b:a",
                    "256k",
                    "-b:a",
                    "256k",
                    "-b:a",
                    "256k",
                    "-b:a",
                    "256k"
                ]
            },
            "skipExisting": false
        },
        "exponential-volume": {
            "enabled": false
        },
        "in-app-menu": {
            "enabled": true,
            "hideDOMWindowControls": false
        },
        "last-fm": {
            "enabled": false,
            "api_root": "http://ws.audioscrobbler.com/2.0/",
            "api_key": "04d76faaac8726e60988e14c105d421a",
            "secret": "a5d2a36fdf64819290f6982481eaffa2"
        },
        "lumiastream": {},
        "lyrics-genius": {
            "romanizedLyrics": true,
            "enabled": true
        },
        "navigation": {
            "enabled": true
        },
        "no-google-login": {},
        "notifications": {
            "enabled": false,
            "unpauseNotification": false,
            "urgency": "normal",
            "interactive": true,
            "toastStyle": 1,
            "refreshOnPlayPause": false,
            "trayControls": true,
            "hideButtonText": false
        },
        "picture-in-picture": {
            "enabled": true,
            "alwaysOnTop": true,
            "savePosition": true,
            "saveSize": false,
            "hotkey": "P",
            "pip-position": [
                10,
                856,
                52,
                9,
                9,
                8,
                8
            ],
            "pip-size": [
                450,
                275,
                136,
                63,
                138,
                65,
                452,
                276
            ],
            "isInPiP": false,
            "useNativePiP": false
        },
        "playback-speed": {},
        "precise-volume": {
            "enabled": false,
            "steps": 1,
            "arrowsShortcut": true,
            "globalShortcuts": {
                "volumeUp": "",
                "volumeDown": ""
            }
        },
        "quality-changer": {
            "enabled": true
        },
        "shortcuts": {
            "enabled": true,
            "overrideMediaKeys": false,
            "global": {
                "previous": "",
                "playPause": "Ctrl+NumDec",
                "next": "Ctrl+Enter"
            },
            "local": {
                "previous": "",
                "playPause": "",
                "next": ""
            }
        },
        "skip-silences": {
            "onlySkipBeginning": false,
            "enabled": false
        },
        "sponsorblock": {
            "enabled": false,
            "apiURL": "https://sponsor.ajay.app",
            "categories": [
                "sponsor",
                "intro",
                "outro",
                "interaction",
                "selfpromo",
                "music_offtopic"
            ]
        },
        "taskbar-mediacontrol": {
            "enabled": true
        },
        "touchbar": {
            "enabled": false
        },
        "tuna-obs": {},
        "video-toggle": {
            "enabled": true,
            "hideVideo": false,
            "mode": "disabled",
            "forceHide": false,
            "align": "middle"
        },
        "visualizer": {
            "enabled": true,
            "type": "wave",
            "butterchurn": {
                "preset": "martin [shadow harlequins shape code] - fata morgana",
                "renderingFrequencyInMs": 500,
                "blendTimeInSeconds": 2.7
            },
            "vudio": {
                "effect": "lighting",
                "accuracy": 128,
                "lighting": {
                    "maxHeight": 160,
                    "maxSize": 12,
                    "lineWidth": 1,
                    "color": "#49f3f7",
                    "shadowBlur": 2,
                    "shadowColor": "rgba(244,244,244,.5)",
                    "fadeSide": true,
                    "prettify": false,
                    "horizontalAlign": "center",
                    "verticalAlign": "middle",
                    "dottify": true
                }
            },
            "wave": {
                "animations": [
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "bottom": true,
                            "count": 30,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 20
                        }
                    },
                    {
                        "type": "Cubes",
                        "config": {
                            "top": true,
                            "count": 12,
                            "cubeHeight": 5,
                            "fillColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#F76B1C"
                                ]
                            },
                            "lineColor": "rgba(0,0,0,0)",
                            "radius": 10
                        }
                    },
                    {
                        "type": "Circles",
                        "config": {
                            "lineColor": {
                                "gradient": [
                                    "#FAD961",
                                    "#FAD961",
                                    "#F76B1C"
                                ],
                                "rotate": 90
                            },
                            "lineWidth": 4,
                            "diameter": 20,
                            "count": 10,
                            "frequencyBand": "base"
                        }
                    }
                ]
            }
        },
        "album-actions": {
            "enabled": true
        }
    },
    "__internal__": {
        "migrations": {
            "version": "3.2.1"
        }
    }
}

Additional Information

same happens with Video alignment options and maybe with more

inson1 commented 10 months ago

global shortcuts too