th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.27k stars 485 forks source link

Visualiser - Memory leak #1722

Open B0N3head opened 7 months ago

B0N3head commented 7 months ago

Preflight Checklist

YouTube Music (Application) Version

3.2.2.0

Checklists

What operating system are you using?

Windows

Operating System Version

Windows 11

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

Not tested on older versions

Reproduction steps

Enable visualiser -> butterchun Play any song radio Wait 5hrs check taskmngr and see ytmusic using 700mb for one of its children processes... Wait another 3hrs and see it's at 1.2GB and the visualiser has gone into some alternative mode were it only shows a white circle no colours or cool horizon and has a visibly low fps. Restart app, back to normal. Whole app is under 300mb

Expected Behavior

Not to slowly engulf the system memory

Actual Behavior

Idk, I'm not fluent with electron or ts. Looks like a really slow memory leak tho.

Enabled plugins

Visualiser Adblock Blur nav bar Compact Navigation Sponsor block Taskbar media control

Additional Information

Seems like whoever did the visualiser knew about this issue as the visualiser goes into an alt mode after a while... almost to try stop any further leaking. Idk tho just speculation.

elch01 commented 7 months ago

Experiencing the same issue in Arch Linux, seems to cause stuttering on X11.