[Bug]: Downloader dosen't work on Dual Wan Router

briantho commented 7 months ago

Preflight Checklist

[X] I use the latest version of YouTube Music (Application).
[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.3.2.0

Checklists

[X] I use the portable version of the YouTube Music Application.
[ ] I can reproduce this issue in the official YTM web version.

What operating system are you using?

Windows

Operating System Version

Windows 11 23H2

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

Have the downloader plugin enabled.
Play a song
Click the 3 vertical dots menu to bring up the context menu.
Click the download button

Expected Behavior

I expect to be able to download a song.

Actual Behavior

Sometimes the downloader works, but about 75% of the time it fails with the message Argh! Apologies Download Failed... nct::ERR_FAILED Seems to happen randomly. Sometimes i am able to download several songs no problem. Then, i hit this error, and i keep trying again and again till eventually it works

Enabled plugins

Ad blocker Downloader In app menu Navigation

Additional Information

I would provide a log, but it is unclear to me how to do so...

JellyBrick commented 7 months ago

Are you using a proxy?

briantho commented 7 months ago

Are you using a proxy?

No. I'm not using a proxy. I do have a dual wan load balancing edgerouter set up. I can try disabling one of the wan's but I'm not sure if that will help. Can you explain to me on how to do a debug log???

ArjixWasTaken commented 7 months ago

Can you explain to me on how to do a debug log???

As a general advice, when you want to see logs of GUI applications, you usually launch them from the command line.

In my case, I do:

cd %USERPROFILE%\AppData\Local\Programs\youtube-music
".\YouTube Music.exe"

You just locate where the executable of Youtube Music is, and launch it like I did

ArjixWasTaken commented 7 months ago

Step-by-step video:

https://github.com/th-ch/youtube-music/assets/53124886/ef94a4f2-a143-4aeb-90bb-41b4861f8b75

briantho commented 7 months ago

Ah ok. I thought there was something else you had to do. I didn't realize all I needed to do was run it from cli. I'm not able to test this right now, but should be able to in a few hours. I'll post the output once I get a chance

briantho commented 7 months ago

This is the error/output I get. Let me know what I should try

NotShige commented 7 months ago

Same problem here too! When downloading my Liked Songs playlist, once it hits around 250 songs, the program crashes without any notice but shows up on the logs.

cmd_rld7BntwvV

Trying to continue downloading the songs on where it stopped results in an error message like above at first, but then when I restart the program it works again. Very weird.

JellyBrick commented 7 months ago

Same problem here too! When downloading my Liked Songs playlist, once it hits around 250 songs, the program crashes without any notice but shows up on the logs.

Trying to continue downloading the songs on where it stopped results in an error message like above at first, but then when I restart the program it works again. Very weird.

This issue was fixed at https://github.com/th-ch/youtube-music/commit/fd6ba1eda113e703792c0ffef4f27c8e48e137a7

NotShige commented 7 months ago

@JellyBrick Slightly different error this time after compiling from source, happens on both .mp3 and Source preset.

Also noticed that this message shows up when I select the .mp3 preset.

cmd_Kui5b0OjUj

JellyBrick commented 7 months ago

@NotShige Are you using a 32-bit version of Windows?

JellyBrick commented 7 months ago

@NotShige Are you experiencing the same issue after 55c934a?

briantho commented 7 months ago

OK, so I decided to try and disable wan2 of my dual wan setup. The Problem immediately went away. I was able to download 20 songs in my liked music, with 0 problems. I reenabled wan2, ran the same test, and sure enough about 6 songs into downloading the error came back... @JellyBrick is there any way to get this working with a dual wan setup? I know dual wan is not a common thing in most homes, but I would greatly appreciate it if you could figure it out

CheeseFort commented 6 months ago

I am experiencing the same issue as @briantho. I am not using dual wan. My internet is Carrier-grade NAT with t-mobile home internet.

briantho commented 6 months ago

I am experiencing the same issue as @briantho. I am not using dual wan. My internet is Carrier-grade NAT with t-mobile home internet.

ah, very interesting. I forgot to mention, the wan2 on my router is using starlink, which is in turn using cgnat. now it all makes sense, since I'm using load balancing some packets go through my local isp cable provider, and some go through starlink. In my test, i tried disabling wan2, aka starlink. I'll try disabling wan1, aka my local ISP cable provider tomorrow, and see if downloading works though starlink only. If that's the case, then it's not a dual wan issue, but a issue with CGnat. I'll test tomorrow and report back.