[Bug]: Crossfade, Volume fader does not properly handle switching between songs

Scream034 commented 7 months ago

Preflight Checklist

[X] I use the latest version of YouTube Music (Application).
[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.3.6

Checklists

[X] I use the portable version of the YouTube Music Application.
[ ] I can reproduce this issue in the official version of (WEB) YTM.

What operating system are you using?

Windows

Operating System Version

Windows 11 Pro 22H2 x64

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

Enable the CrossFade plugin.
Start playing a song (song 1).
While the fade is in progress, switch to a different song (song 2).
Go back to any song (song 1).
You can't hear any song until you update the volume slider.

Expected Behavior

To hear the songs next.

Actual Behavior

I can't hear the song.

Enabled plugins

Crossfade

Additional Information

No response

Edit: I fix mistakes

InInfinitumEtInTenebris commented 5 months ago

Thanks for adding this bug report. I was highly confused as to why my music was not producing audio until I came across this report. I had initially thought it was some error with the adblock, considering Youtube's recent skipping of videos while adblock is on through browser.

successtheman commented 4 months ago

it also seems to have issues when you go forward in a track or backwards before the song ends and then the volume issue also occurs

dingerr commented 4 weeks ago

I am having the same issue / issues. Thanks for posting this, please fix this asap.. Also what specific settings do you use for crossfade plugin that work and most consistent for you? thanks and hope to hear back from yall soon!

dingerr commented 2 weeks ago

not sure about you guys but this is still happening to me constantly.. it's incredibly annoying.. .

ArjixWasTaken commented 2 weeks ago

I suspect the code that checks if the current video/song has changed is buggy

https://github.com/th-ch/youtube-music/blob/master/src%2Fplugins%2Fcrossfade%2Findex.ts#L202-L224

ArjixWasTaken commented 2 weeks ago

Will investigate later this day.

th-ch / youtube-music