th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.25k stars 485 forks source link

[Bug]: No Minimum Screen Size Limit #2200

Open SubhamSubhasisPatra opened 3 months ago

SubhamSubhasisPatra commented 3 months ago

Preflight Checklist

YouTube Music (Application) Version

3.3.12.0

Checklists

What operating system are you using?

Windows

Operating System Version

Windows 11

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Open the app, and try to resize the window from the corner.
  2. the issue is you will be able to resize till the navigation bar.

Expected Behavior

While resize the app, the window should not allow to minimise more after a certain height and width.

Actual Behavior

When u size the screen it is like a tiny screen.

Screenshot 2024-07-04 113816

Enabled plugins

Nothing

Additional Information

No response

ArjixWasTaken commented 3 months ago

Why is this an issue?

patYczakus commented 3 months ago

@SubhamSubhasisPatra there's no limit in height - you can also make this height on any browser (for example Edge) However @ArjixWasTaken, there is no limit in width, and as a result, the appearance becomes distorted and the buttons with In-app menu plugin enabled overlap with standard buttons. This problem can be solved I think

Too small width image

Good width, but overlapping buttons image

ArjixWasTaken commented 3 months ago

Why is it an issue though? Do windows get automatically resized to the smallest width and height they can have?

It's not like the window gets so small that you cannot restore the size. Is this an actual issue or just nitpicking?

patYczakus commented 3 months ago

Theory of relativity, somebody may take this as a issue, someone not Even thought, better (for my opinion) add some limits, just in case

SubhamSubhasisPatra commented 3 months ago

@ArjixWasTaken there should be some restriction on both height and width , if we are not doing that then the UI should be responsive, In my opinion overlapping of button is not a good thing. Even the screen is very small the close icon should not be overlapping.

SubhamSubhasisPatra commented 2 months ago

@JellyBrick with the shared screenshot you can see that, the minimize button is getting overlapped, either prevent the overlap or change the minimum screen size.

ArjixWasTaken commented 2 months ago

@SubhamSubhasisPatra that's what I'd call a skill issue

The shortcut Win+ will minimize the window, and the shortcut Win+ will maximize it.

If you are on macOS then even more skill issue, this stackoverflow answer may help. Even if we implement a minimum window width and height, it would only force you to not shrink your windows to abnormal sizes.

You can simply not resize your windows to such small sizes, why should we force you to? This is a non-issue, since you can always resize back to a normal width and height.

Are we here to babysit you, by any chance? Yes, it would make sense to force a sensible minimum width and height, but what would that be?

--

Q: When would I consider this an actual issue? A: Only when a user that has a tiling window manager comes here and complains about there being no minimum width and height; I'd imagine in that context it would resize to a small window depending on the window layout they use.

SubhamSubhasisPatra commented 2 months ago

@ArjixWasTaken image look at your screen shot where have u seen this kind of screen behaviour , when u make the screen small that time the button will overlap with the menu bar. If that what we call as a feature then awesome.

Even we don't consider for min screen width then it's CSS issue.

ArjixWasTaken commented 2 months ago

look at your screen shot

that ain't my screenshot

where have u seen this kind of screen behaviour

Of course, I've almost never seen such behaviour, only times I've seen it is on LibreOffice (although that is a glitch)

Even we don't consider for min screen width then it's CSS issue.

still, not an actual issue, the proposed solution is a workaround, not an actual solution