search

th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
7.16k stars 432 forks source link

[Bug]: Syntax Error when downloading #2208

Closed MiekoHikari closed 1 week ago

MiekoHikari commented 2 weeks ago

Preflight Checklist

YouTube Music (Application) Version

3.3.12.0

Checklists

What operating system are you using?

Windows

Operating System Version

Edition Windows 11 Home Version 23H2 Installed on ‎6/‎28/‎2024 OS build 22631.3737 Experience Windows Feature Experience Pack 1000.22700.1009.0

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

(assuming fresh install)

  1. Enable the downloader plugin
  2. Login with Google
  3. Change download directory
  4. Works for a while, after listening to multiple songs you will get an error pop up

Expected Behavior

The song to download

Actual Behavior

image Syntax Error in all songs

Enabled plugins

  1. Discord Rich Presence
  2. Ad blocker (also doesn't work)
  3. In-App Menu
  4. Navigation

Additional Information

It works after I delete all user data in %appdata% but the issue appears again after a while

TecnikOfficial commented 2 weeks ago

experiencing same issue but adblocker working ( with blocklists )

4096Richard commented 2 weeks ago

I do Have this issue too it just happened today even though i have had this for half a year already and never had this issue has anybody figured out anything because deleting the app data doesn't work right now Another note if you enable blocklist in ad blocker it will work

4096Richard commented 2 weeks ago

Another note i wanted to mention i decided to keep rolling back version to see if it was something new but i went all the way back to 2.0.1 and still had that same error something to note while on the version 3.0.0 it didn't give me the syntax error instead a # name error thing just something to note Funny enough Another note i went to down to 1.0.0 it just gave multiple errors and didn't even launch for me

DrWafflePhD commented 2 weeks ago

Same thing, playlists don't work either

Aleuso commented 2 weeks ago

same issue here too

MiekoHikari commented 2 weeks ago

After inspecting the source code and playing with it for a while, I've found that:

This issue seems to be related to a dependency of the YT-MUSIC app (Youtubei.js) Issue#683 in LaunRT/YouTube.js

Downgrading the package doesn't seem to work. (Looks like a change in the youtube API broke the package)

JellyBrick commented 1 week ago

This issue was caused by a breaking change in the YouTube internal API.

See https://github.com/LuanRT/YouTube.js/issues/683

JsThiago commented 1 week ago

Same thing unfortunately

JellyBrick commented 1 week ago

Please do not comment "same here" (this will send a spam notification to everyone who is participating in the issue), instead hit the 👍 button.

MiekoHikari commented 1 week ago

Commit: 0415745 Issue: #2218

The new package version of Youtubei.js fixed this issue; I've tested it on my own machine and it passed all tests like normal.

JellyBrick commented 1 week ago

fixed by #2218