th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
7.76k stars 470 forks source link

[Bug]: Adblocking not working with blocklists #2251

Closed i-a-m-a-k closed 1 month ago

i-a-m-a-k commented 1 month ago

Preflight Checklist

YouTube Music (Application) Version

3.4.1

Checklists

What operating system are you using?

Other Linux

Operating System Version

Arch Linux 6.9.9

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Enable Adblocker
  2. Set it to "with blocklists" option
  3. Change this in config file (according to some previous issues)
    "additionalBlockLists": [
    "https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt"
    ],
  4. Play some song

Expected Behavior

Songs play directly without any ads.

Actual Behavior

I get atleast 2 ads before the music starts.

Enabled plugins

  1. Ad Blocker
  2. Blur Navigation Bar
  3. Bypass age restrictions
  4. In-App Menu
  5. Navigation
  6. No Google Login
  7. Video Toggle

Additional Information

theluminal commented 1 month ago

I have the same problem, all blocking methods don't work. OS: Windows 11, Pop OS (based on Debian)

ACaccel commented 1 month ago

same problem, both "with blocklists" and "in player" don't work OS: Windows 10

CreativeRoy commented 1 month ago

same problem, both "with bocklists" and "in player" don't work. I updated blocklists from a previous thread, and they still don't work OS: Arch

xdpirate commented 1 month ago

Same here, also Europe, running the .deb on KDE neon 6.0 user edition.

Edit: An observation, this does not occur when using the official web UI + uBlock Origin on Firefox. Presumably one of the blocklists in use by uBO hits the right domains.

rndmppl69 commented 1 month ago

Had same problem with it, but thanks to @gabe39 for this , now it's working good so far.

xdpirate commented 1 month ago

@rndmppl69 That seems to work for me as well, and it makes sense that it does since uBO blocks it in the browser.

peter9811 commented 1 month ago
"adblocker": {
  "enabled": true,
  "cache": true,
  "blocker": "With blocklists",
  "additionalBlockLists": [
    "https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/unbreak.txt",
    "https://adguard.com/en/filter-rules.html?id=2",
    "https://adguard.com/en/filter-rules.html?id=3",
    "https://adguard.com/en/filter-rules.html?id=14",
    "https://easylist.to/easylist/easylist.txt",
    "https://easylist.to/easylist/easyprivacy.txt",
    "https://fanboy.co.nz/fanboy-annoyance.txt",
    "https://fanboy.co.nz/fanboy-antifacebook.txt",
    "https://fanboy.co.nz/fanboy-social.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/privacy.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/badware.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/filters.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/thirdparties/easylist/easyprivacy.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/thirdparties/easylist/easylist.txt",
    "https://raw.githubusercontent.com/NanoAdblocker/NanoFilters/master/NanoMirror/NanoFilters/NanoDefender.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/annoyances.txt",
    "https://raw.githubusercontent.com/yous/YousList/master/youslist.txt",
    "https://easylist-downloads.adblockplus.org/antiadblockfilters.txt"
  ],
  "disableDefaultLists": false
}

This one is working for me. maybe is a overkill, but...

gabe39 commented 1 month ago
"adblocker": {
  "enabled": true,
  "cache": true,
  "blocker": "With blocklists",
  "additionalBlockLists": [
    "https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/unbreak.txt",
    "https://adguard.com/en/filter-rules.html?id=2",
    "https://adguard.com/en/filter-rules.html?id=3",
    "https://adguard.com/en/filter-rules.html?id=14",
    "https://easylist.to/easylist/easylist.txt",
    "https://easylist.to/easylist/easyprivacy.txt",
    "https://fanboy.co.nz/fanboy-annoyance.txt",
    "https://fanboy.co.nz/fanboy-antifacebook.txt",
    "https://fanboy.co.nz/fanboy-social.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/privacy.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/badware.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/filters.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/thirdparties/easylist/easyprivacy.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/thirdparties/easylist/easylist.txt",
    "https://raw.githubusercontent.com/NanoAdblocker/NanoFilters/master/NanoMirror/NanoFilters/NanoDefender.txt",
    "https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/annoyances.txt",
    "https://raw.githubusercontent.com/yous/YousList/master/youslist.txt",
    "https://easylist-downloads.adblockplus.org/antiadblockfilters.txt"
  ],
  "disableDefaultLists": false
}

This one is working for me. maybe is a overkill, but...

Hmm... it's interesting that it works for you. I remember trying this way some time ago, and the app would refuse to work, giving me an error. That's why I had to merge them into one list using the site that I found by accident.

i-a-m-a-k commented 1 month ago

This works for me as well. Thanks @peter9811 @rndmppl69 and @gabe39 Should I close this issue?

theluminal commented 1 month ago

It works for me as well. Thank you all for the solution!

i-a-m-a-k commented 1 month ago

Since it is working for others as well, I am closing this issue.

phantomwhale commented 1 month ago

Just flagging up for anyone else that I was still running with one line in my blocklist config (https://github.com/th-ch/youtube-music/issues/2150#issuecomment-2229949331) and today suddenly couldn't avoid ads (in-player or blocklists) after the 3.5.1 upgrade, but even a downgrade didn't fix it.

Adding the full list of ad blocks that @gabe39 has fixed things up for me though; overkill for the win!