search

th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
9.08k stars 514 forks source link

[Bug]: Plugin In-App-Menu seems to lag out the UI #2266

Open Shadowphoenix opened 4 months ago

Shadowphoenix commented 4 months ago

Preflight Checklist

YouTube Music (Application) Version

3.4.1

Checklists

What operating system are you using?

Windows

Operating System Version

22H2

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

3.3.9 i think

Reproduction steps

Enable plugin In-App-Menu

Expected Behavior

A UI that isnt laggy to hell and back

Actual Behavior

HUGE Stutters when UI is refreshing for example when moving the mouse across a playlist.

Enabled plugins

In-App-Menu

Shadowphoenix commented 4 months ago

More Details to be found in #2155

JellyBrick commented 4 months ago

Could you provide the URL of playlist?

Shadowphoenix commented 4 months ago

Could you provide the URL of playlist?

its basically any playlist, specifically large ones like my 900-song YTM-Curated Favorite Songs.

That being said i can not reproduce this issue reliably myself. I did some more testing and Whenever it happens there is no (know-to-me, at least) stress on the Computer - if anything i see downwardsspikes of the CPU- and Graphicsloads, as if the two of them were waiting for something else to load. This leads me to the following idea:

There was a similar bug, that was haunting KDE Plasma for a while. Certain workspaceeffects, primarily Windowswitching like "The Cube", would lead to several-second-long stutters and the workspace completely freezing up. because the underlying QML was being loaded from a drive that was already operating at IOPS-capacity. hence pushing said drive EEEEEEEEEVER so slightly over the edge of what it could do. HOWEVER, unlike with said KDEbug, I' can not detect any significant spikes in Harddrive- or Networkactivity before or after the stutters in YTM happen.

EDIT: https://youtu.be/sCoioLCT5_o?si=qcqAKlbzYjE5d0sm Brodie explains really well how the Bug/Issue in Plasma came to be. As Such, it might give you an idea what to look for in the event that something similar is happening in YTM.

JellyBrick commented 2 months ago

It was caused by #1992.

https://github.com/th-ch/youtube-music/blob/199d912823629a154711429d205265b5d336ade3/src/plugins/in-app-menu/titlebar.css#L8

For some reason, using overflow: scroll prevents YTM's virtual scrolling from being applied correctly.

DereC4 commented 1 month ago

It's crazy how the css tag was causing all this performance issue 😭

can reproduce, I made this track to test with 5k songs and it shows extreme loading times

https://music.youtube.com/playlist?list=PLmIc9g0HzInoowGaHHMXsD9UTOa90m8YB&si=XvxOWF6TktiPLnxB

DereC4 commented 1 month ago

It was caused by #1992.

https://github.com/th-ch/youtube-music/blob/199d912823629a154711429d205265b5d336ade3/src/plugins/in-app-menu/titlebar.css#L8

For some reason, using overflow: scroll prevents YTM's virtual scrolling from being applied correctly.

any fix coming up ? :0