th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.85k stars 498 forks source link

[Bug]: Downloader not working at all #2301

Closed Zyanbob closed 3 months ago

Zyanbob commented 3 months ago

Preflight Checklist

YouTube Music (Application) Version

3.5.0

Checklists

What operating system are you using?

Windows

Operating System Version

Windows 11 Home version 22H2

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Enable downloader

Expected Behavior

Downloads playlists

Actual Behavior

The download button in the playlist page does nothing and when i try to use the download option in the plugin i get this: Screenshot 2024-08-01 083844

Enabled plugins

  1. Ad blocker
  2. Album color Theme
  3. Caption selector
  4. Discord Rich Presence
  5. Downloader
  6. In-App Menu
  7. Genius Lyrics
  8. Navigation
  9. Scrobbler
  10. Sponsor Block
  11. Taskbar Media Control
  12. Video Quality Changer

Additional Information

No response

Techconix commented 3 months ago

Well, is your playlist public like it says? If so, then send the link and I should be able to view it. If I can't view it, then it is private.

Zyanbob commented 3 months ago

https://music.youtube.com/playlist?list=PL_UerZgCzqagaRsH5gi98y8168MqR704Y&si=fd0_Y-c1TMvRx8zT

Techconix commented 3 months ago

I created a copy of the playlist by clicking the three dots, save to playlist, and then creating a new playlist to copy it. But now the download button doesn't anything so that's as far as I can get

ArjixWasTaken commented 3 months ago

I created a copy of the playlist by clicking the three dots, save to playlist, and then creating a new playlist to copy it. But now the download button doesn't anything so that's as far as I can get

Is that playlist by any chance private?

Zyanbob commented 3 months ago

is this just going to become a cycle?

Zyanbob commented 3 months ago

downloader doesn't work > person 2 asks persons 1 "is the playlist private?" > person 1 gives person 2 the playlist > person 2 makes a copy and runs into the same problems > person 3 ask person 2 "is the playlist private". the cycle repeats until we runout of people who care about this app

ArjixWasTaken commented 3 months ago

Looks like youtube did some changes and broke a dependency we are using to handle the downloads. That dependency appears to have a fix available, but has not released a new version, so we can't use it yet.

https://github.com/LuanRT/YouTube.js

once a version newer than 10.2.0 comes out, we should be able to use it and likely fix this issue

Zyanbob commented 3 months ago

like the one released 3 minutes ago? https://github.com/LuanRT/YouTube.js/releases/tag/v10.3.0

ArjixWasTaken commented 3 months ago

most likely