th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
9.18k stars 518 forks source link

[Bug]: can't upgrade via brew #2305

Open iwex opened 4 months ago

iwex commented 4 months ago

Preflight Checklist

YouTube Music (Application) Version

3.5.0

What operating system are you using?

macOS

Operating System Version

Sonoma 14.5

What CPU architecture are you using?

arm64 (including Apple Silicon)

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

brew upgrade --greedy

Expected Behavior

Upgrade version

Actual Behavior

==> Upgrading 1 outdated package: th-ch/youtube-music/youtube-music v3.5.0 -> v3.5.0 ==> Upgrading youtube-music ==> Downloading https://github.com/th-ch/youtube-music/releases/download/v3.5.0/YouTube-Music-3.5.0-arm64.dmg Already downloaded: /Users/sc/Library/Caches/Homebrew/downloads/669ec0f286b256f4d85559a8bb60ba0b2bb55a92c774f146a51f1ce1706da248--YouTube-Music-3.5.0-arm64.dmg Warning: No checksum defined for cask 'youtube-music', skipping verification. ==> Backing App 'YouTube Music.app' up to '/opt/homebrew/Caskroom/youtube-music/v3.5.0/YouTube Music.app' ==> Removing App '/Applications/YouTube Music.app' ==> Purging files for version v3.5.0 of Cask youtube-music Error: th-ch/youtube-music/youtube-music: Directory not empty @ rb_file_s_rename - (/opt/homebrew/Caskroom/youtube-music/v3.5.0, /opt/homebrew/Caskroom/youtube-music/v3.5.0.upgrading)

Enabled plugins

No

Additional Information

No response

iwex commented 4 months ago

Why it's trying to update from v3.5.0 -> v3.5.0

th-ch commented 3 months ago

👋 opened https://github.com/th-ch/homebrew-youtube-music/pull/5 to hopefully fix the rb_file_s_rename errors!

gmcinalli commented 2 months ago

Hi @th-ch, unfortunately the fix doesn't seem to work.

==> Upgrading 1 outdated package:
th-ch/youtube-music/youtube-music v3.5.3 -> v3.5.3
==> Upgrading youtube-music
==> Downloading https://github.com/th-ch/youtube-music/releases/download/v3.5.3/YouTube-Music-3.5.3-arm64.dmg
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/182306991/b2f1023e-6814-4ffb-8fb1-c4a17cf7fb64?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240923%2Fus-e
#################################################################################################################################################################################################################################### 100.0%
Warning: No checksum defined for cask 'youtube-music', skipping verification.
==> Removing directories if empty:
/opt/homebrew/Caskroom/youtube-music
/opt/homebrew/Caskroom/youtube-music/v3.5.2
/opt/homebrew/Caskroom/youtube-music/v3.5.2/YouTube Music.app
/opt/homebrew/Caskroom/youtube-music/v3.5.2/YouTube Music.app/Contents
==> Backing App 'YouTube Music.app' up to '/opt/homebrew/Caskroom/youtube-music/v3.5.3/YouTube Music.app'
==> Removing App '/Applications/YouTube Music.app'
==> Purging files for version v3.5.3 of Cask youtube-music
Error: th-ch/youtube-music/youtube-music: No such file or directory @ rb_file_s_rename - (/opt/homebrew/Caskroom/youtube-music/.metadata/v3.5.3, /opt/homebrew/Caskroom/youtube-music/.metadata/v3.5.3.upgrading)
Alorse commented 1 month ago

@gmcinalli I had to remove /opt/homebrew/Caskroom/youtube-music/ folder, then remove /Applications/YouTube Music.app App, and then install it again brew install th-ch/youtube-music/youtube-music

gmcinalli commented 1 month ago

@Alorse Thanks, as far as I remember I've already done these steps, but I'll try again.

gmcinalli commented 1 month ago

I think the problem is here, I currently have version 3.5.3 installed, but brew thinks I have 3.6.1 installed.

image
Alorse commented 1 month ago

@gmcinalli That's why you can't use the upgrade command, as I mentioned, first delete the folder and the app and then do a clean installation.

gmcinalli commented 1 month ago

@Alorse Ok, that’s right, but I’ve to do that for every upgrade?

Alorse commented 1 month ago

@gmcinalli well, I'm not the creator of the App, I'm just another user who faced the same problem as you, hopefully @th-ch will fix it for future versions.

th-ch commented 1 month ago

👋 Looked at it, indeed the problem seems to be around using the numbered version - I switched the formula to use :latest which hopefully should fix the issue!

DianaSensei commented 1 month ago

👋 Looked at it, indeed the problem seems to be around using the numbered version - I switched the formula to use :latest which hopefully should fix the issue!

when will this fix be applied?

D3478 commented 1 month ago

Even the installation isnt working through brew

D3478 commented 1 month ago

Even the installation isnt working through brew

ArjixWasTaken commented 1 month ago

Why are you repeating urself?

dmuiX commented 1 week ago

@gmcinalli I had to remove /opt/homebrew/Caskroom/youtube-music/ folder, then remove /Applications/YouTube Music.app App, and then install it again brew install th-ch/youtube-music/youtube-music

Deleting the folder helps!