th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.99k stars 512 forks source link

[Bug]: Lyrics don't load if sync lyrics enabled #2310

Closed pdario closed 3 months ago

pdario commented 3 months ago

Preflight Checklist

YouTube Music (Application) Version

3.5.1

Checklists

What operating system are you using?

Windows

Operating System Version

Windows 11

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

3.4.x

Reproduction steps

Enable sync lyrics

Expected Behavior

See lyrics

Actual Behavior

image

Enabled plugins

Various

Additional Information

No response

ArjixWasTaken commented 3 months ago

Why did I close this you may ask? Because you gave literally no fucking info, great, lemme start reading minds.

There are many similar issues that have been resolved, but how can I know if this is one of them?

ArjixWasTaken commented 3 months ago

Spend some more effort on your description and I will re-open this if applicable

pdario commented 3 months ago

Whoa! What a reaction! Keep calm and politely ask for the information you need. I updated to v 3.5.1, enabled sync lyrics plugin and now I see as in the screenshot. What do you need more??

JellyBrick commented 3 months ago

Why did I close this you may ask? Because you gave literally no fucking info, great, lemme start reading minds.

Please respect each other's opinions and keep the conversation polite...

pdario commented 3 months ago

Still I can't understand why this is "not planned" and "invalid" @JellyBrick

ArjixWasTaken commented 3 months ago

Whoa! What a reaction! Keep calm and politely ask for the information you need. I updated to v 3.5.1, enabled sync lyrics plugin and now I see as in the screenshot. What do you need more??

It ain't my job to ask for info, if you want to file an issue/bug report, then provide as much info as you can.

A very very very similar issue was already reported earlier and it got resolved, how can I know if this is related to that or a completely new issue?

I do not believe that I was rude from the way I talked, the only rude part would be closing your issue before getting the details that were left out.

What I did was express frustration and close your issue for being invalid.

What is an invalid issue? It is an issue that gives no useful information.

ArjixWasTaken commented 3 months ago

Why was I frustrated you may ask?

Well, the only thing you can achieve by not giving details is waste our time.

I value my time as it ain't a lot.

pdario commented 3 months ago

You, for sure, have a different view about what's rude and what's not, but it does not matter here. I also understand your frustration, as I also had, years ago, to deal with unuseful bug reports, but, for the same reason, I can't see what other information may help you. Maybe something is relevant to you and not to me. The list of all the apps I have installed? I don't think so... List of enabled plugin? Maybe, but it's not easy to dump that with their configuration, I'll avoid that if that does not matter to you.

And for the same reason again, I don't agree it's not your job to ask for clarifications about a bug report. I always politely asked for them.

I hope you can see the point.

I didn't find any issue that has a manual fix. I saw version 3.5.1 fixed something about sync lyrics, but it didn't work for me.

I want to help, but I don't see how to do it efficiently. Please let me help you...

ArjixWasTaken commented 3 months ago

Your config would be a good place to start Enabled plugins, their settings, etc

ArjixWasTaken commented 3 months ago

A title describing the issue would also be nice

pdario commented 3 months ago

I'm sorry I didn't see I missed the bug's title; I added it now.

Enabled plugins: Adblocker / Blocker In-App Ambient mode Audio compressor Dowloader Exponential volume In-App Menu Lyrics Genius Navigation Notifications PlaybackSpeed Precise Volume Shortcuts Skip Disliked Songs Skip Silences Synced Lyrics Taskbar Media Control Tuna OBS

ArjixWasTaken commented 3 months ago

And for the same reason again, I don't agree it's not your job to ask for clarifications about a bug report.

asking for clarifications is indeed my job, but I do not consider it a clarification if there is nothing to clarify

ArjixWasTaken commented 3 months ago

(I hid the off-topic comments to make this thread easier to manage)

7ih commented 3 months ago

I have the same issue. This should fix it: https://github.com/th-ch/youtube-music/pull/2318 (fixes undefined album name when searching for lyrics)