[Feature Request]: Show original lyrics if no lyrics on LRCLIB - Githubissues

th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)

https://th-ch.github.io/youtube-music/

MIT License

9.13k stars 517 forks source link

[Feature Request]: Show original lyrics if no lyrics on LRCLIB #2316

Open sxxeun09 opened 4 months ago

sxxeun09 commented 4 months ago

Preflight Checklist

[X] I use the latest version of YouTube Music (Application).
[X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

Currently, when a song has no synced lyrics available on LRCLIB, the app displays a "⚠️ - No lyrics found for this song." message. This affects songs that previously displayed original from musixmatch, etc.... This change has reduced the usability for songs without synced lyrics.

Before:

After:

LIBLRC:

Proposed Solution

If no synced lyrics are found on LRCLIB, fallback to displaying the original. This ensures that users can still see the lyrics even if synced versions are unavailable.

Alternatives Considered

Manual Syncing: Allow users to manually search on LRCLIB and another lyrics platforms.

Additional Information

No response

ArjixWasTaken commented 4 months ago

I don't know if I should close this issue or not. You see, multiple lyric sources are on my TODO list for this plugin.

They were there from the start (see dead PR for refined-lyrics)

ArjixWasTaken commented 4 months ago

I guess I can keep it open as a tracking issue

azzimihr commented 1 week ago

any progress on this? wouldnt even be an issue if synced lyrics didnt require a restart

ArjixWasTaken commented 1 week ago

any progress on this? wouldnt even be an issue if synced lyrics didnt require a restart

Blocked by https://github.com/th-ch/youtube-music/pull/2383