search

th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
7.99k stars 479 forks source link

[Bug]: (Synced Lyrics): Lyrics stuck at the end when song ends and another one starts #2323

Closed Dzheremi2 closed 1 week ago

Dzheremi2 commented 1 month ago

Preflight Checklist

YouTube Music (Application) Version

3.5.1

Checklists

What operating system are you using?

Other Linux

Operating System Version

Fedora 40, kernel: 6.9.11-200.fc40.x86_64

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Enable Plugin Synced lyrics
  2. Play a track
  3. Open Lyrics tab
  4. Wait for track to be ended and next track is playing

Expected Behavior

Lyrics change and listing from start

Actual Behavior

Lyrics stuck at the one of ending strings

https://github.com/user-attachments/assets/556c9e79-9b31-419c-b20f-7165816f4b3e

Enabled plugins

  1. Downloader
  2. In-App menu
  3. Precise volume
  4. MPRIS
  5. Discord Rich Presence
  6. Music Togethed
  7. Synced Lyrics

Additional Information

No response

ArjixWasTaken commented 1 month ago

does this consistently happen?

Dzheremi2 commented 1 month ago

does this consistently happen?

Yes, It is. Every time when music switches automatically. If I switch It manually, everything goes right.

ArjixWasTaken commented 1 month ago

I cannot reproduce this on my computer. This is a wild guess, but it might be a performance issue (?)

What is your power profile on windows fedora? Is it on Performance/Balanced or Power saver?

And if it is on Power saver, does changing it to Performance/Balanced fix this issue?

Dzheremi2 commented 1 month ago

I cannot reproduce this on my computer. This is a wild guess, but it might be a performance issue (?)

What is your power profile on ~windows~ fedora? Is it on Performance/Balanced or Power saver?

And if it is on Power saver, does changing it to Performance/Balanced fix this issue?

My power profile is Performance

Bugjuice58 commented 1 month ago

I think I know where the issue is as I had the same issue. The video element that it uses to track time sometimes (usually when a song naturally ends, and it plays the next one) keeps the currentTime going, without reset. In my fork I fixed this by doing this: Creating timeOffset var Logic for currentTime - timeOffset When new song plays, change currentTime var I would open a pull request but I'm sure there is a better way to do this.