th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.08k stars 480 forks source link

Serious bug causing system slowdown and crash #295

Closed b-init closed 11 months ago

b-init commented 3 years ago

I built a new version of YTmusic Desktop yesterday via cloning the master repo, and it's been running fine. But just recently, it started to consume too much resources and crashed other running applications, and slowed down my PC. And that happened while it was running under background processes (not playing any music). It's running again fine now. But that may need to be worked on. I wonder if it stores logs and errors anywhere in cache that I could share?

PC's specifications are: Windows 10 20H2 i5 8265U 8 Gigs DDR4 memory

Araxeus commented 3 years ago

What plugins did you have enabled when that happened?

b-init commented 3 years ago

image

Downloader too (I wasn't downloading anything)

Bellisario commented 3 years ago

Could be useful increase app performance during sleep (if no music playing after some minutes), so, some time ago I proposed this functionality: #232.

amerodeh commented 2 years ago

Was playing Monster Hunter World and suddenly got a crash to desktop with no error message or anything, looked at Event Viewer and the following things were there with timestamps at the time of the crash

Windows successfully diagnosed a low virtual memory condition. The following programs consumed the most virtual memory: MonsterHunterWorld.exe (17972) consumed 8878804992 bytes, YouTube Music.exe (18588) consumed 4484780032 bytes, and YouTube Music.exe (21148) consumed 3952488448 bytes.

Application pop-up: Windows - Out of Virtual Memory : Your system is low on virtual memory. To ensure that Windows runs properly, increase the size of your virtual memory paging file. For more information, see Help.

So I guess this app has a memory leak (Monster Hunter World ~9 GB vs YTM ~4.5 GB + ~4 GB). My PC has been running pretty much all day (booted it up in the early afternoon, it's midnight now). btw Not sure why it's reported twice, I have it locked down to one instance using that option within the app. Had barely any plugins enabled bar the default ones too.