search

th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.89k stars 500 forks source link

download option not working anymore? #356

Closed Artan1408 closed 3 years ago

Artan1408 commented 3 years ago

Hey guys, I don't know exactly when this issue started but recently I haven't been able to get the download to work. It says "downloading..." for a long time (like 10-15 min) then I get a error 404 saying download failed! Tried different songs, different playlists and uninstalling/reinstalling didn't fix it either. Appreciate it if anybody could help.

I'm using the latest version (1.12.1) - windows 10

DahrbUwU commented 3 years ago

i get the error 304 about 5 times when i download a playlist. (1.12.2)

arduinka55055 commented 3 years ago

same on manjaro using aur package. it stuck on downloading

also it says /opt/YouTube Music/resources/app.asar/node_modules/ytdl-core/lib/utils.js:175 WARNING: ytdl-core is out of date! Update with "npm install ytdl-core@latest".

also i tried injecting new ytdl-core to asar. will tell results later

i hope you'll fix this

arduinka55055 commented 3 years ago

UPD: injecting new ytdl-core helped

arduinka55055 commented 3 years ago

open terminal in asar location

sudo npx asar extract app.asar destfolder             #unpack it

sudo npm install -g ytdl-core@latest                  #install good ytdl-core
sudo npm install -g --engine-strict asar              #instsall asar if you dont have it

move it https://i.imgur.com/mTgxCOd.png

sudo mv app.asar app_old.asar

sudo asar pack destfolder app.asar

ENJOY downloading ur tracks

i hope i helped someone

th-ch commented 3 years ago

Hey everyone, thanks for the feedback! A new version has been released and should solve the issue, can you give it a try?

Artan1408 commented 3 years ago

Hey everyone, thanks for the feedback! A new version has been released and should solve the issue, can you give it a try?

The update indeed solved the issue, thank you so much :)

th-ch commented 3 years ago

Closing the issue as it seems solved, feel free to re-open if needed!

arduinka55055 commented 3 years ago

btw. i cant download playlist, but can download separate songs

have u met same issue?

Araxeus commented 3 years ago

@arduinka55055

if the playlist you try to download is public, what is the error you're getting?

arduinka55055 commented 3 years ago

hanged on downloading... no errors in console. playlist is public https://music.youtube.com/playlist?list=PLn4IbQPBFMwjFnofhn3_R67Plpdh4gC37&feature=share (songs about git lol, for testing)

Artan1408 commented 3 years ago

hanged on downloading... no errors in console. playlist is public https://music.youtube.com/playlist?list=PLn4IbQPBFMwjFnofhn3_R67Plpdh4gC37&feature=share (songs about git lol, for testing)

Just checked and same issue here, checked with a small playlist (4 songs) too, doesn't work! I never tried to download a whole playlist so I never noticed before, however downloading a single song still works perfectly.