search

th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
7.02k stars 427 forks source link

Some songs will not download #556

Closed valkyrienyanko closed 1 year ago

valkyrienyanko commented 2 years ago

Some songs just say "Downloading..." forever, but other songs download just fine.

Steps to Reproduce

  1. Search for "big shot deltarune drum and bass version"
  2. Try downloading the first top result

OS: Windows 64 Bit

Araxeus commented 2 years ago

There are actually 2 bugs here

  1. The first search result which is named "Top Result" sometimes has a bug:

    • menu doesn't contain the song url like all other menus - instead containing some random playlist url (could only reproduce once, anyways this is a bug in youtube website and not the program)

  2. playlist folder has no name sanitation, meaning that if the playlist name has invalid characters, mkdirSync() will throw an error at - FIXED in #557