th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
8.24k stars 485 forks source link

[Feedback Needed] Split plugins into categories #713

Open Araxeus opened 2 years ago

Araxeus commented 2 years ago

There are currently 25 plugins, which are all listed in alphabetic order in the menu

I think its a bit much, it's hard to read, and also if using the in-app-menu plugin, the list depends on window size (if there isn't enough space, it cuts some of the plugins)

I propose splitting the plugins into categories, which will only affect the menu - each category in its own submenu

Categories could maybe be like:

UI:
  navigation (enable by default?)
  in-app-menu
  video-toggle
  picture-in-picture
  quality-changer
  lyrics-genius
  blur-nav-bar

Playback:
  precise-volume
  exponential-volume
  audio-compressor
  skip-silences
  playback-speed
  disable-autoplay
  sponsorblock (integration?)

Native:
  downloader
  notifications
  shortcuts
  taskbar-mediacontrol
  touchbar

Integrations:
  tuna-obs
  last-fm
  discord
  webnowplaying?

Other/Bypass/?:
  adblocker
  no-google-login
  bypass-age-restrictions

Would love to hear thoughts from anyone about the whole idea, and also specifically the name of the categories and the way they are split

MiepHD commented 2 years ago

I generally like the idea. For Sponsorblock, I'd say to put it in both Playback and Integration if that's possible. For the last category, I'd recommend naming it Other since they really have not that much in common and we'll need this category anyway.

jkrei0 commented 2 years ago

I think that this is definitely a good improvement. I made a mock-up of what I think would be a better solution: Opening an options window when the plugins menu is clicked. I'm not sure how easy/possible this would be to do, but it would be a lot nicer than a bunch of menu/submenu items. image

Either way, I agree something needs to be done. The plugins list is almost taller than my monitor (it actually scrolls a few pixels).

Araxeus commented 1 year ago

TODO since it seems no one has the time to write a full settings menu implementation, maybe use something simpler like https://github.com/snapcrunch/electron-preferences

could take some design inspiration from https://web.dev/building-a-settings-component

Zo-Bro-23 commented 1 year ago

+1 for this

JellyBrick commented 7 months ago

We working on this