search

th3rdwave / react-native-safe-area-context

A flexible way to handle safe area insets in JS. Also works on Android and Web!
MIT License
2.14k stars 197 forks source link

fix:Compatible with version 0.72 #379

Closed NiuGuohui closed 1 year ago

NiuGuohui commented 1 year ago

Summary

The Geometry.h file is deprecated and will be removed in the next version of React Native.

jacobp100 commented 1 year ago

What are we using from this file?

NiuGuohui commented 1 year ago

What are we using from this file?

I don't know, but it will be an error in RN0.72.

jacobp100 commented 1 year ago

What versions of RN does this file exist in? Will we be breaking older versions?

janicduplessis commented 1 year ago

I think we need to import RectangleEdges.h not Float.h since we are using the EdgeInsets type, this is where it is defined.

I verified and this header was added a very long time ago so it will be backwards compatible.

NiuGuohui commented 1 year ago

I think we need to import RectangleEdges.h not Float.h since we are using the EdgeInsets type, this is where it is defined.

I verified and this header was added a very long time ago so it will be backwards compatible.

You're right!