search

th3rdwave / react-native-safe-area-context

A flexible way to handle safe area insets in JS. Also works on Android and Web!
MIT License
2.08k stars 191 forks source link

install_modules_dependencies(s) outside of use_fabric #417

Open billnbell opened 12 months ago

billnbell commented 12 months ago

https://github.com/th3rdwave/react-native-safe-area-context/blob/930f703ca3337f407e2df13d1f4ec8e9ffcdb654/react-native-safe-area-context.podspec#L24

This line for install_module_dependencies(s) is in wrong spot.

See: https://reactnative.dev/docs/the-new-architecture/backward-compatibility-fabric-components

Please take use_fabric off, and remove dependencies.

billnbell commented 12 months ago

Test it with:

cd ios && NO_FLIPPER=1 USE_FRAMEWORKS=static RCT_NEW_ARCH_ENABLED=1 pod install --repo-update && cd .. && yarn ios
janicduplessis commented 12 months ago

install_module_dependencies is not available in older rn versions so I prefer not to use it outside of fabric for now.