search

th3rdwave / react-native-safe-area-context

A flexible way to handle safe area insets in JS. Also works on Android and Web!
MIT License
2.14k stars 197 forks source link

ViewProps type import #445

Closed jaredspeters closed 11 months ago

jaredspeters commented 11 months ago

Looks like there's a minor TypeScript issue with the import for ViewProps. I've patched it in our project to stop linter complaints.

diff --git a/node_modules/react-native-safe-area-context/src/SafeAreaContext.tsx b/node_modules/react-native-safe-area-context/src/SafeAreaContext.tsx
index c813e48..e0b4585 100644
--- a/node_modules/react-native-safe-area-context/src/SafeAreaContext.tsx
+++ b/node_modules/react-native-safe-area-context/src/SafeAreaContext.tsx
@@ -1,5 +1,6 @@
 import * as React from 'react';
-import { Dimensions, StyleSheet, ViewProps } from 'react-native';
+import { Dimensions, StyleSheet } from 'react-native';
+import type { ViewProps } from 'react-native';
 import { NativeSafeAreaProvider } from './NativeSafeAreaProvider';
 import type {
   EdgeInsets,

This issue body was partially generated by patch-package.

jacobp100 commented 11 months ago

Could you do this as a PR?

jaredspeters commented 11 months ago

PR here: https://github.com/th3rdwave/react-native-safe-area-context/pull/446