jacobp100
commented
11 months ago Are you using fabric?
Closed ravindraguptacapgemini closed 10 months ago
jacobp100
commented
11 months ago Are you using fabric?
ravindraguptacapgemini
commented
11 months ago @jacobp100 Yes
jacobp100
commented
10 months ago That's the kind of stuff you should include in your message
This library currently has experimental support for the new react-native architecture. Note that there will be breaking changes and only the latest version of react-native will be supported.
ravindraguptacapgemini
commented
10 months ago @jacobp100 any timeline to get this one fixes?
I tried to upgrade app to React Native 0.73.0-rc.4, but this library is not building at all with c++ errors:
FAILED: CMakeFiles/appmodules.dir/Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp.o /Users/ravindragupta/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ --target=aarch64-none-linux-android21 --gcc-toolchain=/Users/ravindragupta/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64 --sysroot=/Users/ravindragupta/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -Dappmodules_EXPORTS -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native/ReactAndroid/cmake-utils/default-app-setup -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-vector-icons/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-vector-icons/android/build/generated/source/codegen/jni/react/renderer/components/RNVectorIconsSpec -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@bugsnag/react-native/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@bugsnag/react-native/android/build/generated/source/codegen/jni/react/renderer/components/BugsnagReactNativeSpec -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@pushpendersingh/react-native-scanner/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@pushpendersingh/react-native-scanner/android/build/generated/source/codegen/jni/react/renderer/components/RNReactNativeScannerViewSpec -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@react-native-async-storage/async-storage/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@react-native-async-storage/async-storage/android/build/generated/source/codegen/jni/react/renderer/components/rnasyncstorage -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@react-native-community/datetimepicker/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@react-native-community/datetimepicker/android/build/generated/source/codegen/jni/react/renderer/components/RNDateTimePickerCGen -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@react-native-community/geolocation/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/@react-native-community/geolocation/android/build/generated/source/codegen/jni/react/renderer/components/RNCGeolocation -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-gesture-handler/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-gesture-handler/android/build/generated/source/codegen/jni/react/renderer/components/rngesturehandler_codegen -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-permissions/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-permissions/android/build/generated/source/codegen/jni/react/renderer/components/rnpermissions -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/../../../../common/cpp -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/../../../build/generated/source/codegen/jni -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/../../../build/generated/source/codegen/jni/react/renderer/components/safeareacontext -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/../../../../common/cpp -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/../../../build/generated/source/codegen/jni -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/../../../build/generated/source/codegen/jni/react/renderer/components/rnscreens -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-webview/android/build/generated/source/codegen/jni/. -I/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-webview/android/build/generated/source/codegen/jni/react/renderer/components/RNCWebViewSpec -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/fabricjni/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/82bf628b06ff8fd05e9d07046003b0c2/transformed/jetified-fbjni-0.5.1/prefab/modules/fbjni/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/folly_runtime/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/glog/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/jsi/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_codegen_rncore/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_debug/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_utils/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_nativemodule_core/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_newarchdefaults/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_render_componentregistry/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_render_core/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_render_debug/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_render_graphics/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_render_imagemanager/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_render_mapbuffer/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/rrc_image/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/rrc_view/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/rrc_legacyviewmanagerinterop/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/runtimeexecutor/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/turbomodulejsijni/include -isystem /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/yoga/include -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fno-limit-debug-info -fPIC -Wall -Werror -Wno-error=cpp -fexceptions -frtti -std=c++20 -DWITH_INSPECTOR=1 -DLOG_TAG=\"ReactNative\" -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1 -MD -MT CMakeFiles/appmodules.dir/Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp.o -MF CMakeFiles/appmodules.dir/Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp.o.d -o CMakeFiles/appmodules.dir/Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp.o -c /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp:21: In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/safeareacontext.h:6: /Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/../../../../common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewComponentDescriptor.h:15:60: error: non-virtual member function marked 'override' hides virtual member function void adopt(ShadowNode::Unshared const &shadowNode) const override { ^ /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_nativemodule_core/include/react/renderer/core/ConcreteComponentDescriptor.h:172:16: note: hidden overloaded virtual function 'facebook::react::ConcreteComponentDescriptor::adopt' declared here: type mismatch at 1st parameter ('facebook::react::ShadowNode &' vs 'const ShadowNode::Unshared &' (aka 'const shared_ptr &'))
virtual void adopt(ShadowNode& shadowNode) const override {
^
In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp:21:
In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/safeareacontext.h:6:
/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-safe-area-context/android/src/main/jni/../../../../common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewComponentDescriptor.h:21:40: error: non-const lvalue reference to type 'facebook::react::ShadowNode' cannot bind to a value of unrelated type 'const ShadowNode::Unshared' (aka 'const shared_ptr')
ConcreteComponentDescriptor::adopt(shadowNode);
^::adopt' declared here: type mismatch at 1st parameter ('facebook::react::ShadowNode &' vs 'const ShadowNode::Unshared &' (aka 'const shared_ptr &'))
virtual void adopt(ShadowNode& shadowNode) const override {
^
In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp:23:
In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/rnscreens.h:19:
/Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/../../../../common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h:36:40: error: non-const lvalue reference to type 'facebook::react::ShadowNode' cannot bind to a value of unrelated type 'const ShadowNode::Unshared' (aka 'const shared_ptr')
ConcreteComponentDescriptor::adopt(shadowNode);
^
~~~~~ /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_nativemodule_core/include/react/renderer/core/ConcreteComponentDescriptor.h:172:34: note: passing argument to parameter 'shadowNode' here virtual void adopt(ShadowNode& shadowNode) const override { ^ In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/build/generated/rncli/src/main/jni/rncli.cpp:23: In file included from /Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/rnscreens.h:19: /Users/ravindragupta/Desktop/Projects/mobilev2/native/node_modules/react-native-screens/android/src/main/jni/../../../../common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h:15:60: error: non-virtual member function marked 'override' hides virtual member function void adopt(ShadowNode::Unshared const &shadowNode) const override { ^ /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_nativemodule_core/include/react/renderer/core/ConcreteComponentDescriptor.h:172:16: note: hidden overloaded virtual function 'facebook::react::ConcreteComponentDescriptor~~~~~ /Users/ravindragupta/.gradle/caches/transforms-3/cad32421dc5982419efab7efe732c3fa/transformed/jetified-react-android-0.73.0-rc.4-debug/prefab/modules/react_nativemodule_core/include/react/renderer/core/ConcreteComponentDescriptor.h:172:34: note: passing argument to parameter 'shadowNode' here virtual void adopt(ShadowNode& shadowNode) const override { ^ 4 errors generated. ninja: build stopped: subcommand failed.C++ build system [build] failed while executing: /Users/ravindragupta/Library/Android/sdk/cmake/3.22.1/bin/ninja \ -C \ /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app/.cxx/Debug/4e6m2qi1/arm64-v8a \ appmodules \ react_codegen_BugsnagReactNativeSpec \ react_codegen_RNCGeolocation \ react_codegen_RNCWebViewSpec \ react_codegen_RNDateTimePickerCGen \ react_codegen_RNReactNativeScannerViewSpec \ react_codegen_RNVectorIconsSpec \ react_codegen_rnasyncstorage \ react_codegen_rngesturehandler_codegen \ react_codegen_rnpermissions \ react_codegen_rnscreens \ react_codegen_safeareacontext from /Users/ravindragupta/Desktop/Projects/mobilev2/native/android/app
BUILD FAILED in 15s error Failed to install the app. Command failed with exit code 1: ./gradlew app:installNormalDebug -PreactNativeDevServerPort=8081 FAILURE: Build failed with an exception. * What went wrong: