search

th3rdwave / react-native-safe-area-context

A flexible way to handle safe area insets in JS. Also works on Android and Web!
MIT License
2.14k stars 197 forks source link

Do not specify paperName for event `onInsetsChanged` #476

Closed cortinico closed 6 months ago

cortinico commented 6 months ago

Summary

Library is currently failing to work on 0.74.0-RC2 due to the library accidentally (?) specifying a paper event name for the onInsetsChange event. The logic in core has changed here: https://github.com/facebook/react-native/commit/76613ec4cd0379649a1cca9c0079b8e6bcdc2663

As the paper event name is not used at all in native code, it's safe to remove entirely.

Test Plan

Before After
Screenshot_1709911266 Screenshot_1709911093
janicduplessis commented 6 months ago

Thanks @cortinico !

cortinico commented 6 months ago

cc @brentvatne

cortinico commented 6 months ago

@janicduplessis can we get another RC with this fix included?

janicduplessis commented 6 months ago

Sure, will do that today

janicduplessis commented 6 months ago

published as 4.10.0-rc.1