search

th3rdwave / react-navigation-bottom-sheet

MIT License
423 stars 18 forks source link

Fullscreen on Android #23

Open Robert27 opened 1 month ago

Robert27 commented 1 month ago

iOS uses FullWindowOverlay to achieve a fullscreen modal. Is something like this also possible on Android?

janicduplessis commented 1 month ago

In general on android it shouldn’t be needed. On iOS it allows to render on top of screens that have a modal presentation, otherwise it will display under the modal screen and won’t be visible. Is there a case on android where this is a problem?

Robert27 commented 1 month ago

I use the BottomSheet within BottomTabs with Expo Router. On iOS, the sheet covers the BottomBar, on Android the sheet only starts above the BottomBar.

I have already experimented, if you remove the ModalProvider here and instead place one in the root stack of the app, then the bottom sheet also covers the bottom bar on Android.

https://github.com/th3rdwave/react-navigation-bottom-sheet/blob/ef8c616559a3fdbb67149d6e1ebc9bb662d71255/src/BottomSheetView.tsx#L137

Therefore, I would suggest an option with which you can deactivate the internal provider, by just returning a react fragment.