search

th3rdwave / react-navigation-bottom-sheet

MIT License
428 stars 19 forks source link

Use BottomSheetModalProps instead of BottomSheetProps as navigation options #8

Closed codybrouwers closed 2 years ago

codybrouwers commented 2 years ago

Hey there, thanks for this library, it has been very useful!

I came across an issue that this PR attempts to fix. I wanted to use the stackBehavior option but it is added by BottomSheetModalProps. Since this library's BottomSheetView component does use the BottomSheetModal abstraction from @gorhom/bottom-sheet, I believe this library's props should also inherit the same props.

I think this might also fix this issue:

Thank you!

janicduplessis commented 2 years ago

Thanks!