With your additional commit (after PR #145), you removed the duplicate edit parameter from CompilerJob. I'd remove it completely from SyntaxUpdaterProcessBuilderFactory, because there it is set only if no editor is open. However, the compiler closes the editor, anyway. So now, the editor would be closed and reopened even though the edit parameter is not set at all.
Also, I suggest invoking the syntax update only if compilation is active (see comment 1 in #145)
thSoft
commented
6 years ago
With your additional commit (after PR #145), you removed the duplicate edit parameter from CompilerJob. I'd remove it completely from SyntaxUpdaterProcessBuilderFactory, because there it is set only if no editor is open. However, the compiler closes the editor, anyway. So now, the editor would be closed and reopened even though the edit parameter is not set at all.
Also, I suggest invoking the syntax update only if compilation is active (see comment 1 in #145)