thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

marker logic #153

Closed nittka closed 6 years ago

nittka commented 6 years ago

The PR addresses #148. The main modifications are that outdated-markers are removed only by the LilyPond compiler and that they are removed only if actual compilation took place.

Only if the compiler was really invoked can we be sure that the output is up to date. The UP_TO_DATE-marker logic seems obsolete.

I experimented with a modified recompile hash for indicating that a recompile is necessary - using a normalized text representation without hidden nodes (i.e. without white spaces or comments). The idea is, that the output will be the same if comments are added, spaces, i.e. no structural changes have taken place. The problem is that with those modifications the score hyperlinks are still affected. So if click-to-point generation is disabled the modified hash is OK, if it is enabled recompile is necessary to get the correct hyperlinks. Currently, I would not consider it worth making this distinction in the index information creation. If it is important to you, I can add it (let me know).

thSoft commented 6 years ago

Thank you, this also simplifies things!