thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

always open workspace external files read only #161

Closed nittka closed 6 years ago

nittka commented 6 years ago

This PR ensures that workspace external files are opened read only. As a consequence https://github.com/thSoft/eclipse-commons/pull/43 will not cause problems.

thSoft commented 6 years ago

Hmm, on second thought, we do want to support editing non-workspace files, don't we?

nittka commented 6 years ago

Well, maybe. But for now, this is the safer option (and consisent with the previous behaviour).

There are some problems with writable workspace external files:

My current argument is that if some sources you want to edit are not already in some workspace project, you can use import file system (import as a linked folder) in order to get them into the workspace.