search

thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

add file location to editor title tooltip #163

Closed nittka closed 6 years ago

nittka commented 6 years ago

With this PR the tooltip in the editor's title (tab) will not only contain the file name or workspace relative location but also the file system location. This should be helpful in particular if files outside the workspace are open (e.g. default includes, absolute includes or relative includes leaving the workspace), but possibly also for workspace files (projects linked from different file system locations).

nittka commented 6 years ago

Please wait with merging this PR. As I wrote in https://github.com/thSoft/eclipse-commons/pull/46 currently each score to source link will be opened in a new editor. This is cause by https://github.com/thSoft/elysium/commit/4d40d413fc133f80ea686c500ba4748670fcc0b3

As a consequence of wrapping the editor input to make it read only, Eclipse does not recognize that the same target file is already open. I am currently investigating an alternative way to make the editor input read only. As a consequence the tooltip may have to be calculated differently, so this PR may be obsolete.

If everything turns out OK, both F3 from an including file as well as score to source navigation pointing to a file outside the workspace might recognize already open files.

nittka commented 6 years ago

This is obsolete with #164.