search

thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

Separate syntax updating from compiling #170

Closed nittka closed 6 years ago

nittka commented 6 years ago

This PR addresses #167. Syntax update is removed from the compilation. A separate syntax update job is introduced. The syntax updater preferences are separated from the compiler preferences.

nittka commented 6 years ago

I reused the console as it is (including the static getter) because it was not a public class. Moving the job would require opening up the console API (make FACTORY public... etc.). Would this be fine with you? I would not like to duplicate the console code...

How about renaming CompilerConsole to LilyPondConsole, placing it an a "console" package and keep the static getter methods there (getCompilerConsole(IFile) and getSyntaxUpdaterConsole())? This seems a clean approach to me.

I will make the changes after the other PR is finished - as the CompilerJob is involved in both, I want to keep the merge conflicts to a minimum.

thSoft commented 6 years ago

How about renaming CompilerConsole to LilyPondConsole, placing it an a "console" package and keep the static getter methods there (getCompilerConsole(IFile) and getSyntaxUpdaterConsole())?

Yes, this would be the cleanest approach. Could you please perform these refactorings?

nittka commented 6 years ago

Of course - will be done soon.

nittka commented 6 years ago

I have rebased the branch on master and made the console refactoring as discussed.

thSoft commented 6 years ago

Cool, thanks!