File refactorings

[nittka]

This PR addresses #134.

• refactorings have been adapted to file system location rather than workspace project relative location
• resolution unit tests for windows and unix paths (given that the paths given as arguments are correct)
• delete of source file deletes compiled files as well (analogous to rename/move - also multiple midi files)
• refactorings on virtual folders/linked files are ignored as they do not modify the underlying file
• I have tried out the refactorings for relative, absolute and search path includes on a windows and a linux machine.

The current implementation has some small limitations

• refactorings (involving search path relative includes) moving included/included files into/out of the search path may cause problems

I guess search paths are usually used for default includes which are more or less static (so refactoring will not really happen). Virtual folders/linked files will probably hardly used. So these limitations are not too problematic.

What do you think of the following enhancements for the refactoring preference page; add preferecence

• for disabling Refactoring participant completely (default refactoring enabled)
• for disabling automatic include modification (default include modification enabled)
• for disabling "delete included file" warning (default warning enabled)
• for disabling deleting compiled files when deleting a source (default deleting compiled enabled)

[thSoft]

Thanks, I ask for your patience, I'm going to review this and your other PRs this Thursday.

[nittka]

I addressed your comments. If possible, I would like to extract the multiple compiled files issue to a separate ticket (as the changes require more than just removing the file extension filtering to midi). Could you also briefly comment on the potential preference page enhancement mentioned in the initial comment? If you think them worth implementing, a separate ticket could be opened.

[nittka]

It seems, I addressed the issues and forgot to push... I am sorry back, that I missed the typo (fixed now) ;-)

[thSoft]

Thanks for performing the requested changes! Regarding your questions:

If possible, I would like to extract the multiple compiled files issue to a separate ticket (as the changes require more than just removing the file extension filtering to midi).

OK.

What do you think of the following enhancements for the refactoring preference page; add preferecence for disabling Refactoring participant completely (default refactoring enabled)

This would be useful.

for disabling automatic include modification (default include modification enabled)

What are the cases where it can corrupt things?

for disabling "delete included file" warning (default warning enabled)

This would be useful (maybe with a "Don't ask this again" in the dialog).

for disabling deleting compiled files when deleting a source (default deleting compiled enabled)

This would also be useful.

[nittka]

I'll open a new ticket for the preference page enhancements. Allowing to disabling the include modifications would be a safety measure. I don't know the problem cases, but if the logic destroys the includes e.g. when moving files, users may not be too happy. The preference allows users to say: "I'll deal with adapting the includes myself."

Multiple compiled files refactoring was dealt with in the last commit of this PR.