search

thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

#25 fix multi line comment auto edit #191

Closed nittka closed 6 years ago

nittka commented 6 years ago

This PR addresses #25. Auto edit for multi line comments failed because the strategy was not registered for the single line comment partition, but if the prefix is % this will be the current partition.

This current fix also involves not registering regular braces {} for the comment partition. This is because braces and multiline comment strategy will fire simultaneously leading to strange results when pressing enter between %{ and %}. This is the simplest solution. Of course auto edit for braces will now not work when in a comment or multi line comment, which I consider acceptable. Otherwise we would have to sub class the strategy and apply it for braces only if there was no percent befor the brace.

thSoft commented 6 years ago

Great, thank you for the fix of this old bug! Of course, it is acceptable if auto edit for braces in comments is not working.