search

thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

Compilation cancelling doesn't work #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Cancelling a compilation process has no effect. This is particulary bad when 
recompiling a file quickly twice in a row, as there can be a file writing 
conflict between the two processes.

Original issue reported on code.google.com by harmathdenes on 3 Aug 2012 at 9:38

nittka commented 9 years ago

There are two main reasons why the current implementation of CompilerJob does no cancelling.

  1. the run method makes no use of the monitor which provides information about the cancel status
  2. The ProcessBuilder class does not seem to provide any hook for cancelling and ProcessUtils.runProcess returns the process only after it is finished.

A second thread checking the monitor and destroying the process (rather than CompilerJob#canceling which kicks in too late) might be an option.

thSoft commented 9 years ago

@nittka May I please ask you to also implement a UI button on the Console view? Then this issue would be completed.

nittka commented 9 years ago

@thSoft I can try, cannot make promises on the time line, though.

thSoft commented 9 years ago

:D Don't worry, I have not established any deadlines. However, I would like to perform a release some time before Mars.