search

thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

configurable file content in new project wizard #76

Closed nittka closed 9 years ago

nittka commented 9 years ago

Possible fix for #41 by providing a preference page.

nittka commented 9 years ago

The constants may not be private, as they are used in the preference page class as well - binding the editors to the preference values. I think it is OK as it is. A public enum (as for the compiler preferences) is not necessary, as the values are not used anywhere outside the package.

I adapted the code according to the second comment, but wait with the commit until I have your OK.

thSoft commented 9 years ago

Of course they cannot be private then. :D But final indeed. Sorry for nitpicking. :)

nittka notifications@github.com ezt írta (2015. június 15., hétfő):

The constants may not be private, as they are used in the preference page class as well - binding the editors to the preference values. I think it is OK as it is. A public enum (as for the compiler preferences) is not necessary, as the values are not used anywhere outside the package.

I adapted the code according to the second comment, but wait with the commit until I have your OK.

— Reply to this email directly or view it on GitHub https://github.com/thSoft/elysium/pull/76#issuecomment-112089211.

thSoft commented 9 years ago

Thanks for the contribution!