search

thSoft / elysium

LilyPond IDE for Eclipse
http://elysium.thsoft.hu
14 stars 3 forks source link

improve Markup hack #78

Closed nittka closed 9 years ago

nittka commented 9 years ago

Before (possibly) attempting a more complete grammar review, a slight modification of the markup handling seems to improve integration test success rate.

By forcing a markup command list to end on the first line without indentation, more assignments will be recognized as such. A further point to discuss would be including titling-init.ly to the default imports. One integration test suggests that LilyPond works that way.

Currently, the tests check only, if the files can be processed successfully. For regression, at least problematic cases should be tested more thoroughly. For example, a dumb grammar accepting any input would succeed for parsing the files as well! So, some semantics could (and for regression cases should) be checked as well (number of assignments in a file).

thSoft commented 9 years ago

Whew, these are huge improvements, thanks! I'll review them soon. titling-init.ly doesn't get included because of #79.

thSoft commented 9 years ago

Awesome, this halved the integration test failures! Also, thanks for the gitignore improvements, I always forget to use this git workaround for source folders.