Closed nittka closed 9 years ago
I will fix the typos. For now (the upcoming release), I would leave the hash function as it is. It considers the complete file content and hence also if click and point coordinates change, so functionally it is OK but may cause unnecessary builds. Improving the hash to consider only relevant changes can be part of a new optimization ticket - costs for calculating that hash have to be taken into account.
Okay! Thanks for increasing the pass rate even further!
I have made changes to the indexing and scoping, in particular eliminating the PropertyAssignment (for some reason it was impossible to give both assignment types a common super type - all attempts lead to compile errors in the generated code).
SchemeIdentifier-like names seem to be valid for assignmnets - at least LilyPond accepted my-UpBow = \upbow
If there are restrictions in that direction, it is much easier to deal with them in the validator than in the grammar.
Please comment on the modifications in the LilyPondResourceDescriptionStrategy. I could not find a reason to put all elements in the index. Click and point worked with the simplified version as well. This way the index is much smaller and much faster to build (improved performance for the integrationtests).