search

thabti / react-native-css

Style React-Native components with css
MIT License
769 stars 66 forks source link

Unsupported properties should be ignored #22

Closed caiosba closed 8 years ago

caiosba commented 8 years ago

Right now if there is a property in the input CSS that is not supported by React Native, it will crash. It would be good to just ignore them.

caiosba commented 8 years ago

Created a pull request at #23

thabti commented 8 years ago

PR accepted, @caiosba when you get a chance can you add tests for that PR?

caiosba commented 8 years ago

Added tests and opened a new PR for that at #25

thabti commented 8 years ago

@caiosba awesome thank you. https://circleci.com/gh/sabeurthabti/react-native-css/107

zhouzi commented 8 years ago

Right now if there is a property in the input CSS that is not supported by React Native, it will crash.

Doesn't that mean you're using invalid CSS? If that's the case, it's probably better to be noticed early on or you'll end up with unknown bugs.

jeffpearce commented 8 years ago

Not necessarily. You might be reusing css from a web project; RN supports only a subset of CSS.

Sent from my iPhone

On Jun 8, 2016, at 7:52 AM, Gabin Aureche notifications@github.com wrote:

Right now if there is a property in the input CSS that is not supported by React Native, it will crash.

Doesn't that mean you're using invalid CSS? If that's the case, it's probably better to be noticed early on or you'll end up with unknown bugs.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.