thackl / gggenomes

A grammar of graphics for comparative genomics
https://thackl.github.io/gggenomes/
Other
587 stars 64 forks source link

Fix empty attributes check in read_gff3 #157

Closed iimog closed 1 year ago

iimog commented 1 year ago

The original check used vectorized conditions with || and inside if. This is potentially problematic and results in errors rather than warnings starting from R version 4.2.0 Fix #156

The updated version now checks, whether all elements are NA or empty. I assume this is also the desired behaviour, as previously a leading semicolon would have caused all attributes to be ignored.