Drop ellipsis dependency + avoid tidyselect deprecated syntax

thackl / gggenomes

A grammar of graphics for comparative genomics

https://thackl.github.io/gggenomes/

Other

587 stars 64 forks source link

Drop ellipsis dependency + avoid tidyselect deprecated syntax #193

Open olivroy opened 3 months ago

olivroy commented 3 months ago

Increase dependency on R 3.5 (due to usage of ...length(). (although 4.1 is actually required due to some usage of |>.

Increased dependency on dplyr 1.1 (relocate() is used in the code)

More info https://dplyr.tidyverse.org/articles/programming.html

rlang also provides dots_n() which can be used.

Also added website to DESCRIPTION for discoverability

thackl commented 3 months ago

Thanks @olivroy for checking these! I'll have to time to check/merge things probably next week.

Going forward, I'm planning to move to R 4.1, though. I'm going to use |> in all new code and I'm currently porting all examples to |> as well.

olivroy commented 3 months ago

Sounds good! Yeah, I noticed #164, but didn't want to overstep since it was unnecessary to this PR. If you have difficulty following, and / or would like me to split this in 2 PRs, let me know!