thadunge2 / AIDungeon

Other
51 stars 32 forks source link

Password prompts #73

Closed pirone2 closed 4 years ago

pirone2 commented 4 years ago

When playing the game after manually fixing the "missing parenthesis" crash, the input box works like a password box and doesn't show what you're typing.

It only happens when it's actually waiting for input, ie: doesn't happen while the game is initializing until it asks for new or load game Editing the box element and making it a "text" instead of "password" only fixes it until it asks your next input.

I suspect it might be related to the newly commited encryption feature since it uses passwords, but it might have nothing to do with it.

pirone2 commented 4 years ago

Ah, and of course, apparently it's just a visual thing, the obscured commands and inputs seem to work normally.

pirone2 commented 4 years ago

Oh, found something new about it. The text shows normally while it's processing an input. Like: ->You type and send something in password format ->While it's processing you type whatever in the box and it shows normally ->When it stops processing and gives you its output your typed normal text becomes password format again

machiavel23 commented 4 years ago

https://github.com/cloveranon/Clover-Edition/issues/39#issuecomment-569966313

RyushoYosei commented 4 years ago

Yeah I'm having this issue now myself .

irregarde commented 4 years ago

I'm also having this issue. When I manually change the widget element to "text," it's reset to "password" after one input. My current browser is Chrome v. 81.0.4014.0 (Official Build) canary (64-bit).

machiavel23 commented 4 years ago

The problem is cause by a module named readline. We had a hard time with clover figuring it out. the best you can do for now on thadunge edition until he removes it from his fork is to manually edit some .py files (at least utils.py and play.py) to remove any readline import. You can easily do it with colab file editor, and can spot where are the readline lines by checking the commits on clover's github.

thadunge2 commented 4 years ago

Fixed by #76