search

thaider / Tweeki

MediaWiki skin based on Twitter's Bootstrap
http://tweeki.kollabor.at
Other
128 stars 31 forks source link

Deprecated ResourceLoader #240

Closed rebastion closed 1 year ago

rebastion commented 2 years ago

Doesn't seem to break anything, but on 1.38.2 I get the following error shown in the console: This page is using the deprecated ResourceLoader module "skins.tweeki.styles". [1.37] The use of thelegacyfeature with ResourceLoaderSkinModule is deprecated(T89981). More information can be found at [[mw:Manual:ResourceLoaderSkinModule]].

tazzytazzy commented 2 years ago

I've been poking around and it's related to this patch: https://phabricator.wikimedia.org/T89981

I'm not sure how to fix it just yet.

rebastion commented 2 years ago

So MW has "fixed" this on their side and now skins can better chose if and what legacy resources they load, do I read this right?

thaider commented 1 year ago

Thanks for reporting!

thaider commented 1 year ago

Could you please check, if this is fixed in master? Should probably also solve most of the styling issues...

rebastion commented 1 year ago

is 2.0.2 identical with master right now (assuming so)? I'll upgrade all skin files to 2.0.2 later and report back. EDIT: still seeing this in the console after upgrading to 2.0.2

thaider commented 1 year ago

The change was after 2.0.2. Can you try master or do you need a tag for some reason?

rebastion commented 1 year ago

With master, I still get the error "This page is using the deprecated ResourceLoader module "skins.tweeki.styles". [1.37] The use of the content-thumbnails feature with ResourceLoaderSkinModule is deprecated. Use content-media instead. More nformation can be found at [[mw:Manual:ResourceLoaderSkinModule]].

thaider commented 1 year ago

Could you try again, please? I don't see anything in console. Do you know if you have some debugging setting on so you can see the deprecation notifications?

rebastion commented 1 year ago

Show exception details is set to false; I emptied several layers of caching (memcache, varnish, mediawiki's own, my browser's) and used a fresh/blank browser, and tried on three browsers. I always see this error in the console. Retried various times. Not sure if there's any other caching I could be missing that would be so invasive?

thaider commented 1 year ago

My post might have been not clear enough. Did you pull latest master?

rebastion commented 1 year ago

yes, right after your comment yesterday

rebastion commented 1 year ago

Went through two more loops of emptying caches, re-uploading LocalSettings and re-uploading latest master of Tweeking, and now the error message was shortly gone at least on one browser. On others, I still see it, but not always on all pages. Might have something to do with what kind of content the skin is displaying.........

rebastion commented 1 year ago

No longer able to reproduce.